Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Adds Permutation Importance #13146
[MRG] Adds Permutation Importance #13146
Changes from 7 commits
00c56de
29be4f4
2e09bfb
f7bb490
6f0175c
bf44eb1
85ed781
66e71dd
a93a9f3
ee1e77f
0670997
334c8c3
354ac62
260fa54
92894a1
f45c653
50d8550
74e915f
2a7d8e2
920362a
747599b
a48e151
51b745d
23c8d11
4241414
a12bc0c
e864071
9a57e20
5798338
72b9003
37d52ba
fe675f9
ced888d
b0357fc
91bf4e2
a1d5880
4eb1e82
6f98f11
1656985
0d34d80
62868f6
e7efe6d
d75b557
e3bbcda
6c60e43
ed469d6
6180975
24d740e
914335d
f0beac6
ac8d5a3
31e9408
be3f65b
e1df6a6
78aba62
d6ca3c5
a2aa960
9ff6aa1
f112cd3
884d648
c64e6a1
d2fad37
50b6b98
14b3efd
f41f5b3
3cd43ce
318c961
aa6c79d
5292136
9b53e35
bc3ea96
7d79a49
b487618
7a83608
af9c961
664d863
8a022c6
78ed4e8
fbebc5e
d62df83
118601a
9f1325f
2655f82
ca9a78b
1748227
e1607ff
fb4f926
eb154a9
b1f9c70
946ca59
5676930
78cefef
204c3ab
dab6801
c67667f
f90eacf
6b428d7
94c4c56
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it mean when this value is negative? Do we need to clip in that case??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Negative means that the model performed better with the feature permuted. This could mean that the feature should be dropped.
There is a paragraph about this in https://explained.ai/rf-importance/index.html at Figure 3(a)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. I think both the docstring and the user guide should explain the meaning of negative importance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a reference - and a user guide!