Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Fix #13152 - pypy failure in doctest of extract_patches_2d #13178

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
4 participants
@fferrin
Copy link

fferrin commented Feb 17, 2019

Reference Issues/PRs

Fixes #13152

What does this implement/fix? Explain your changes.

There was an error in the docstring of feature_extraction.image.extract_patches_2d function when checking the values of the patches. That was because it was using the wrong image.

Any other comments?

@fferrin

This comment has been minimized.

Copy link
Author

fferrin commented Feb 17, 2019

I just realized that nothing has changed. I do not know what the problem was, but if it persists, it's because of the image index.

@ogrisel

This comment has been minimized.

Copy link
Member

ogrisel commented Feb 21, 2019

So it's a random failure? That's really weird.

@thomasjpfan

This comment has been minimized.

Copy link
Contributor

thomasjpfan commented Feb 21, 2019

While working on azure pipelines, I noticed this failure once on linux python 3.7. It has not appeared again.

@ogrisel

This comment has been minimized.

Copy link
Member

ogrisel commented Feb 21, 2019

Yes, I also got it once locally with CPython 3.7. It's not specific to PyPy.

@rth

This comment has been minimized.

Copy link
Member

rth commented Feb 25, 2019

While working on azure pipelines, I noticed this failure once on linux python 3.7. It has not appeared again.

Currently, CI on master fails because of it https://dev.azure.com/the-real-scikit-learn/scikit-learn/_build/results?buildId=69 and we are also seeing it e.g. in #13234

@thomasjpfan

This comment has been minimized.

Copy link
Contributor

thomasjpfan commented Feb 25, 2019

I am looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.