Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Configures Travis CI to fail fast #13218

Merged
merged 7 commits into from Feb 22, 2019

Conversation

Projects
None yet
2 participants
@thomasjpfan
Copy link
Member

commented Feb 22, 2019

Configures Travis CI to fail fast. At the start of a test, if there is a newer test running, this script will exit with an error early. This check is done twice: right before installation, and right after installation.

I think this would help with lighten up the load on travis ci. Note, if pytest already started the test will run till completion.

This comes from the 1-based indexing folks at Julia: https://github.com/JuliaLang/julia/blob/master/contrib/travis_fastfail.sh

thomasjpfan added some commits Feb 22, 2019

@thomasjpfan thomasjpfan reopened this Feb 22, 2019

@thomasjpfan

This comment has been minimized.

Copy link
Member Author

commented Feb 22, 2019

For OSX, using addons for homebrew saves 3 minutes, since it does not update homebrew (by default).

@ogrisel

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

Let's merge this to check that this works on PR before the sprint starts.

@ogrisel ogrisel merged commit d19a5dc into scikit-learn:master Feb 22, 2019

18 checks passed

LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: doc Your tests passed on CircleCI!
Details
ci/circleci: doc-min-dependencies Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 9c6de2f...f5fe420
Details
codecov/project 92.48% (+<.01%) compared to 9c6de2f
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
scikit-learn.scikit-learn Build #20190222.7 succeeded
Details
scikit-learn.scikit-learn (Linux py35_conda_openblas) Linux py35_conda_openblas succeeded
Details
scikit-learn.scikit-learn (Linux py35_np_atlas) Linux py35_np_atlas succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_conda) Linux pylatest_conda succeeded
Details
scikit-learn.scikit-learn (Windows py35) Windows py35 succeeded
Details
scikit-learn.scikit-learn (Windows py37) Windows py37 succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda) macOS pylatest_conda succeeded
Details

xhlulu added a commit to xhlulu/scikit-learn that referenced this pull request Apr 28, 2019

xhlulu added a commit to xhlulu/scikit-learn that referenced this pull request Apr 28, 2019

xhlulu added a commit to xhlulu/scikit-learn that referenced this pull request Apr 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.