Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX test_svmlight_format.py::test_dump on ARM #13263

Merged
merged 1 commit into from Feb 26, 2019

Conversation

Projects
None yet
3 participants
@rth
Copy link
Member

commented Feb 25, 2019

Closes #13050
Closes #13258 (opened a duplicate issue by mistake)

Fixes the test_svmlight_format.py::test_dump test for ARM 64 bit.

See #13258 (comment) for the description of the issue.

@rth rth added this to the 0.20.3 milestone Feb 25, 2019

@glemaitre
Copy link
Contributor

left a comment

LGTM

@rth rth force-pushed the rth:test-svmlight-arm branch from c56caea to 50bf0d6 Feb 26, 2019

@agramfort agramfort merged commit 2f35e9e into scikit-learn:master Feb 26, 2019

18 checks passed

LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: doc Your tests passed on CircleCI!
Details
ci/circleci: doc-min-dependencies Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 92.48%)
Details
codecov/project 92.52% (+0.03%) compared to b61283d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
scikit-learn.scikit-learn Build #20190226.28 succeeded
Details
scikit-learn.scikit-learn (Linux py35_conda_openblas) Linux py35_conda_openblas succeeded
Details
scikit-learn.scikit-learn (Linux py35_np_atlas) Linux py35_np_atlas succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_conda) Linux pylatest_conda succeeded
Details
scikit-learn.scikit-learn (Windows py35) Windows py35 succeeded
Details
scikit-learn.scikit-learn (Windows py37) Windows py37 succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda) macOS pylatest_conda succeeded
Details
@agramfort

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

thx @rth

jnothman added a commit to jnothman/scikit-learn that referenced this pull request Feb 26, 2019

@rth rth deleted the rth:test-svmlight-arm branch Feb 28, 2019

xhlulu added a commit to xhlulu/scikit-learn that referenced this pull request Apr 28, 2019

xhlulu added a commit to xhlulu/scikit-learn that referenced this pull request Apr 28, 2019

xhlulu added a commit to xhlulu/scikit-learn that referenced this pull request Apr 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.