This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking at this comment: #13077 (comment), it seemed that before some tests were not run on MetaEstimators, which would mean we would need to add them in the tests ran on CalibratedClassifierCV
But now test_non_meta_estimators appears to have been deleted in #8022, so I think in fact I don't need to add the tests, since now MetaEstimatorsMixin are considered as regular estimators ?
Thanks for the review @qinhanmin2014 and @glemaitre ! I realized that the what's new entry is in v.0.21, should I revert this PR and move it to 0.22 ? Should I add a test too ? Like check with a 3D array for instance that it works ?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.