Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF Don't allocate space for bias element if there isn't one #14108

Merged
merged 1 commit into from Jun 18, 2019
Merged

PERF Don't allocate space for bias element if there isn't one #14108

merged 1 commit into from Jun 18, 2019

Conversation

alexhenrie
Copy link
Contributor

@alexhenrie alexhenrie commented Jun 17, 2019

When doing regression with 65 million samples and no bias, this patch saves 780 megabytes of memory.

Copy link
Member

@jnothman jnothman left a comment

Nice!

@jnothman
Copy link
Member

@jnothman jnothman commented Jun 18, 2019

Please add an entry to the change log at doc/whats_new/v0.22.rst. Like the other entries there, please reference this pull request with :pr: and credit yourself (and other contributors if applicable) with :user:

@alexhenrie
Copy link
Contributor Author

@alexhenrie alexhenrie commented Jun 18, 2019

@jnothman OK I added a brief note and amended the commit. What do you think?

@rth
Copy link
Member

@rth rth commented Jun 18, 2019

I added a brief note and amended the commit.

A minor point just FYI (for the future) better not to amend commits in a PR but add new ones. We squash PRs anyway in the end, and separate commits make it easier to review what changed since the last review. Here the diff is short enough that it's fine in any case.

rth
rth approved these changes Jun 18, 2019
Copy link
Member

@rth rth left a comment

Thanks!

@rth rth merged commit 7ce8b21 into scikit-learn:master Jun 18, 2019
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants