Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF Don't allocate space for bias element if there isn't one #14108

Merged
merged 1 commit into from Jun 18, 2019

Conversation

@alexhenrie
Copy link
Contributor

alexhenrie commented Jun 17, 2019

When doing regression with 65 million samples and no bias, this patch saves 780 megabytes of memory.

Copy link
Member

jnothman left a comment

Nice!

@jnothman

This comment has been minimized.

Copy link
Member

jnothman commented Jun 18, 2019

Please add an entry to the change log at doc/whats_new/v0.22.rst. Like the other entries there, please reference this pull request with :pr: and credit yourself (and other contributors if applicable) with :user:

@alexhenrie alexhenrie force-pushed the alexhenrie:csr branch from 9bfe752 to fd8aec3 Jun 18, 2019
alexhenrie added a commit to alexhenrie/scikit-learn that referenced this pull request Jun 18, 2019
@alexhenrie

This comment has been minimized.

Copy link
Contributor Author

alexhenrie commented Jun 18, 2019

@jnothman OK I added a brief note and amended the commit. What do you think?

@alexhenrie alexhenrie force-pushed the alexhenrie:csr branch from fd8aec3 to 5c381a9 Jun 18, 2019
alexhenrie added a commit to alexhenrie/scikit-learn that referenced this pull request Jun 18, 2019
@alexhenrie alexhenrie force-pushed the alexhenrie:csr branch from 5c381a9 to 851eb0f Jun 18, 2019
alexhenrie added a commit to alexhenrie/scikit-learn that referenced this pull request Jun 18, 2019
@alexhenrie alexhenrie force-pushed the alexhenrie:csr branch from 851eb0f to 854191e Jun 18, 2019
alexhenrie added a commit to alexhenrie/scikit-learn that referenced this pull request Jun 18, 2019
@alexhenrie alexhenrie force-pushed the alexhenrie:csr branch from 854191e to bb68133 Jun 18, 2019
alexhenrie added a commit to alexhenrie/scikit-learn that referenced this pull request Jun 18, 2019
@alexhenrie alexhenrie force-pushed the alexhenrie:csr branch from bb68133 to 54a6d3a Jun 18, 2019
@rth

This comment has been minimized.

Copy link
Member

rth commented Jun 18, 2019

I added a brief note and amended the commit.

A minor point just FYI (for the future) better not to amend commits in a PR but add new ones. We squash PRs anyway in the end, and separate commits make it easier to review what changed since the last review. Here the diff is short enough that it's fine in any case.

@rth
rth approved these changes Jun 18, 2019
Copy link
Member

rth left a comment

Thanks!

@rth rth merged commit 7ce8b21 into scikit-learn:master Jun 18, 2019
16 checks passed
16 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: doc Your tests passed on CircleCI!
Details
ci/circleci: doc-min-dependencies Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing b7c4163...54a6d3a
Details
codecov/project 96.82% remains the same compared to b7c4163
Details
scikit-learn.scikit-learn Build #20190618.7 succeeded
Details
scikit-learn.scikit-learn (Linux py35_conda_openblas) Linux py35_conda_openblas succeeded
Details
scikit-learn.scikit-learn (Linux py35_np_atlas) Linux py35_np_atlas succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_conda) Linux pylatest_conda succeeded
Details
scikit-learn.scikit-learn (Windows py35_32) Windows py35_32 succeeded
Details
scikit-learn.scikit-learn (Windows py37_64) Windows py37_64 succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda) macOS pylatest_conda succeeded
Details
koenvandevelde added a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.