Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
PERF Only call malloc twice in liblinear to_sparse helpers #14170
We looked at it with pierre and it seems fine.
There's one thing not related to this PR still. When the malloc fails, the error is not handled anywhere after in liblinear.pyx (unlike for libswm which handles the error in libsvm.pyx). We should handle it when calling set_problem in liblinear also.