Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[MRG] Deprecated 'copy' in TfidfVectorizer.transform #14520
What does this implement/fix? Explain your changes.
I just deprecated the param as discussed in the issue
Any other comments?
It was my first deprecation in scikit-learn, I don't know if I might be missing anything.
Pleas see https://scikit-learn.org/dev/developers/contributing.html#deprecation
@GuillemGSubies this is the example from the docs:
def example_function(n_clusters=8, k='not_used'): if k != 'not_used': warnings.warn("'k' was renamed to n_clusters in version 0.13 and " "will be removed in 0.15.", DeprecationWarning) n_clusters = k
instead of "not_used" I'd suggest using "deprecated".
So you set