Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[MRG] Adds _MultimetricScorer for Optimized Scoring #14593
What does this implement/fix? Explain your changes.
Any other comments?
I do have plans to support custom callables that return dictionaries from the user. This was not included in this PR to narrow the scope of this PR to
Looks good, I think this could use a few more comments to describe the logic.
I'm not a huge fan of using
Maybe add a sanity check that makes sure that passing another
I find this design of a callable dict that generates a dict uncomfortable. That duplicate use of dicts makes the documentation confusing, apart from anything else.
Is it really justified to make