Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upWeighted average scores no nan #14595
Merged
Conversation
Some metrics can produce NaN scores which are however 0-weighted (e.g. PR curve score calculated on class with no positive ground truth samples in the batch). When directly taking weighted average of them, the NaN scores can cause the average score to be NaN, even if they are 0-weighted. To prevent this, before taking the average, we force the scores with 0 weight to be 0, so that they will not pose effect on the final average score.
This comment has been minimized.
This comment has been minimized.
|
These failures are somewhat disconcerning, in particular because they are version-dependent?! |
This comment has been minimized.
This comment has been minimized.
|
I fix |
This comment has been minimized.
This comment has been minimized.
|
actually good for reviews now. |
|
A small change log entry? |
This comment has been minimized.
This comment has been minimized.
|
What should it say? Allowing averaging metrics in the absence of true positives? Sure. |
This comment has been minimized.
This comment has been minimized.
|
I tend to find "fixed a bug where" helps me formulate something meaningful
for users struck with that issue.
|
adrinjalali
merged commit 1a14920
into
scikit-learn:master
17 checks passed
17 checks passed
scikit-learn.scikit-learn (Linux pylatest_conda_mkl_pandas)
Linux pylatest_conda_mkl_pandas succeeded
Details
scikit-learn.scikit-learn (Linux32 py35_ubuntu_atlas_32bit)
Linux32 py35_ubuntu_atlas_32bit succeeded
Details
scikit-learn.scikit-learn (Windows py35_pip_openblas_32bit)
Windows py35_pip_openblas_32bit succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
amueller commentedAug 7, 2019
Finishes #10891 by adding a regression test.
If there's no positives the code raises a division by zero warning, and there's a test that the warning is raised. I'm not sure if that's useful, but I'm keeping with the current behavior. For the case in #10891 I'm still raising the warning but providing a useful number.