This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have trying to keep using this _plot folder to place the display and plot function into its namespace and only import it in sklearn.inspection. This can not be done here because plot_partial_dependence is already defined publicly in sklearn.inspeciton.partial_dependence. So for only partial_dependence it can be justified to create a _partial_dependence_display.py file.
I won't argue more but I find that having a module with a single file isn't necessary (esp. since it creates other kinds of inconsistencies), and having 3 different files named partial_dependence.py is confusing.
With the current API, is it easy to extend it in the future by allowing e.g. 3d plots instead of contours for 2way pdps?
I have been avoiding 3-d plots. They... add another dimension to plotting. I think current plot_partial_dependence API is kind of bloated with its 2-way partial dependence, I would not want to add more to it.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.