Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Adds Plotting API to Partial Dependence #14646
[MRG] Adds Plotting API to Partial Dependence #14646
Changes from 31 commits
fa93505
d1dc257
1dac62c
bc45123
9d67f6a
5129289
6f5407e
8bc2433
4aa273c
5263235
045aa8f
75f8ed8
5fddc5f
396f1cb
bd121c3
422992e
ca532d7
7316ef5
9b916cf
ec47bd8
170a1b5
9ad9477
cab552a
0f5dee1
e7965d9
24ee8b0
d339328
f7e946d
480bcef
e9e5d3a
4b50a8b
f77f5d1
612a80e
a8182d8
6c3a6c9
42e0c9b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we use Display API now? (also example file name?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not changed the name of how to reference the API. I would still say "visualization API". "Display API" sounds overly generic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, then lowercase (I thought this was a class ^^)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the example but it's pretty condensed and it combines multiple functionalities at once so it's hard to understand how things interact independently.
For example it's a bit confusing at first how you can end up with a 2 by 2 grid while you only asked for 1 column.
I think it's missing a very simple plot with just 1 feature where you combine the curves of the 2 models. Then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a "Plotting partial dependence for one feature" section at the end. With the current API, there are two ways to plot a single feature:
Option 1
Option 2
For the example, I went with option 1. The "nicer" way to do this is:
Possible option that is being disallowed.
The first call will call
ax.set_visible(False)
to denote that the space has been used. The second call will see that the axes is not visible and raise an error. We can technically support this "single feature" and "single axes" case, which I think will add another layer of complexity to the API i.e. "Ifax
is a single axes andlen(features) == 1
, then we behave differently"There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a sentence saying that the length of axes must be equal to the number of features we plot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.