Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
MNT Add estimator check for not calling __array_function__ #14702
I'm not sure how many people install numpy from pypi, but my guess is "many". I'd rather have that, or conda-forge as the "test against the latest" in the CI, rather than conda. WDYT?
The only test is that estimators don't complain when you pass
I think we should have
@amueller I addressed Joel's comments and merged with master. I'm happy to address future comments if you need
Regarding all the changes to sample_weight, I agree with @glemaitre that we could/should be using