Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in implementation of scoring in loo _RidgeGCV #14864

Merged
merged 5 commits into from Sep 8, 2019

Conversation

venkyyuvy
Copy link
Contributor

@venkyyuvy venkyyuvy commented Sep 1, 2019

Reference Issues: #14857

What does this implement/fix? Explain your changes.

Any other comments?

@jnothman
Copy link
Member

@jnothman jnothman commented Sep 2, 2019

Please add a test with an asymmetric score.

Please add an entry to the change log at doc/whats_new/v0.22.rst. Like the other entries there, please reference this pull request with :pr: and credit yourself (and other contributors if applicable) with :user:

@venkyyuvy venkyyuvy changed the title [WIP] Fix bug in implementation of scoring in loo _RidgeGCV [MRG] Fix bug in implementation of scoring in loo _RidgeGCV Sep 4, 2019
Copy link
Member

@agramfort agramfort left a comment

thx @venkyyuvy

@jnothman feel free to MRG

rth
rth approved these changes Sep 8, 2019
Copy link
Member

@rth rth left a comment

Thanks @venkyyuvy !

@rth rth changed the title [MRG] Fix bug in implementation of scoring in loo _RidgeGCV Fix bug in implementation of scoring in loo _RidgeGCV Sep 8, 2019
@rth rth merged commit 2e7b554 into scikit-learn:master Sep 8, 2019
18 checks passed
@venkyyuvy venkyyuvy deleted the loo_scoring branch Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants