Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in implementation of scoring in loo `_RidgeGCV` #14864

Merged
merged 5 commits into from Sep 8, 2019

Conversation

@venkyyuvy
Copy link
Contributor

venkyyuvy commented Sep 1, 2019

Reference Issues: #14857

What does this implement/fix? Explain your changes.

Any other comments?

Venkatachalam N
@jnothman

This comment has been minimized.

Copy link
Member

jnothman commented Sep 2, 2019

Please add a test with an asymmetric score.

Please add an entry to the change log at doc/whats_new/v0.22.rst. Like the other entries there, please reference this pull request with :pr: and credit yourself (and other contributors if applicable) with :user:

Venkatachalam N added 4 commits Sep 4, 2019
@venkyyuvy venkyyuvy changed the title [WIP] Fix bug in implementation of scoring in loo `_RidgeGCV` [MRG] Fix bug in implementation of scoring in loo `_RidgeGCV` Sep 4, 2019
Copy link
Member

agramfort left a comment

thx @venkyyuvy

@jnothman feel free to MRG

@rth
rth approved these changes Sep 8, 2019
Copy link
Member

rth left a comment

Thanks @venkyyuvy !

@rth rth changed the title [MRG] Fix bug in implementation of scoring in loo `_RidgeGCV` Fix bug in implementation of scoring in loo `_RidgeGCV` Sep 8, 2019
@rth rth merged commit 2e7b554 into scikit-learn:master Sep 8, 2019
18 checks passed
18 checks passed
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: doc Your tests passed on CircleCI!
Details
ci/circleci: doc artifact Link to 0/doc/_changed.html
Details
ci/circleci: doc-min-dependencies Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.92%)
Details
codecov/project 96.92% (+<.01%) compared to ae5f558
Details
scikit-learn.scikit-learn Build #20190904.19 succeeded
Details
scikit-learn.scikit-learn (Linux py35_conda_openblas) Linux py35_conda_openblas succeeded
Details
scikit-learn.scikit-learn (Linux py35_ubuntu_atlas) Linux py35_ubuntu_atlas succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_conda_mkl_pandas) Linux pylatest_conda_mkl_pandas succeeded
Details
scikit-learn.scikit-learn (Linux32 py35_ubuntu_atlas_32bit) Linux32 py35_ubuntu_atlas_32bit succeeded
Details
scikit-learn.scikit-learn (Windows py35_pip_openblas_32bit) Windows py35_pip_openblas_32bit succeeded
Details
scikit-learn.scikit-learn (Windows py37_conda_mkl) Windows py37_conda_mkl succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda_mkl) macOS pylatest_conda_mkl succeeded
Details
@venkyyuvy venkyyuvy deleted the venkyyuvy:loo_scoring branch Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.