Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT deprecate outputs_2d_ attribute of dummy estimators #14933

Merged
merged 6 commits into from Sep 15, 2019

Conversation

@NicolasHug
Copy link
Contributor

NicolasHug commented Sep 9, 2019

It is equivalent to n_outputs_ != 1.

closes #14801

Copy link
Member

adrinjalali left a comment

LGTM, we just need a whats new entry for it.

@NicolasHug

This comment has been minimized.

Copy link
Contributor Author

NicolasHug commented Sep 13, 2019

I added an entry.

I feel like we need a different kind of entry for these deprecations which are very minor and do not impact as much as other deprecations. The attribute wasn't ever documented, I doubt people were relying on it.

@adrinjalali

This comment has been minimized.

Copy link
Member

adrinjalali commented Sep 13, 2019

I added an entry.

I feel like we need a different kind of entry for these deprecations which are very minor and do not impact as much as other deprecations. The attribute wasn't ever documented, I doubt people were relying on it.

We need a separate deprecated section IMO, for all the things we're deprecating. But that can be done in a separate PR.

@thomasjpfan

This comment has been minimized.

Copy link
Member

thomasjpfan commented Sep 13, 2019

Lets do the new "deprecated attributes" section now?

@thomasjpfan

This comment has been minimized.

Copy link
Member

thomasjpfan commented Sep 13, 2019

Let do it in another PR, but it needs to be soon. The more attribute we deprecate, the more we have to move things around.

doc/whats_new/v0.22.rst Outdated Show resolved Hide resolved
@rth
rth approved these changes Sep 13, 2019
Copy link
Member

rth left a comment

Minor comment, LGTM otherwise.

sklearn/dummy.py Outdated Show resolved Hide resolved
@rth

This comment has been minimized.

Copy link
Member

rth commented Sep 13, 2019

Let do it in another PR, but it needs to be soon. The more attribute we deprecate, the more we have to move things around.

Can we automate the generation of that? Looks like we are going to deprecate a lot of things. If we had an automated way that would also simplify removals. Though I'm not sure if it's worth spending time on such a system.

@thomasjpfan

This comment has been minimized.

Copy link
Member

thomasjpfan commented Sep 13, 2019

Though I'm not sure if it's worth spending time on such a system.

I would not want to...make it easier to deprecate things ;)

@rth

This comment has been minimized.

Copy link
Member

rth commented Sep 13, 2019

I would not want to...make it easier to deprecate things ;)

Exactly, not sure where we'll stop otherwise :)

doc/whats_new/v0.22.rst Outdated Show resolved Hide resolved
@NicolasHug

This comment has been minimized.

Copy link
Contributor Author

NicolasHug commented Sep 15, 2019

Thanks for the reviews, I addressed the comments

@NicolasHug

This comment has been minimized.

Copy link
Contributor Author

NicolasHug commented Sep 15, 2019

+4 so I'll merge

@NicolasHug NicolasHug changed the title [MRG] MNT deprecate outputs_2d_ attribute of dummy estimators MNT deprecate outputs_2d_ attribute of dummy estimators Sep 15, 2019
@NicolasHug NicolasHug merged commit 84717a9 into scikit-learn:master Sep 15, 2019
18 checks passed
18 checks passed
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: doc Your tests passed on CircleCI!
Details
ci/circleci: doc artifact Link to 0/doc/_changed.html
Details
ci/circleci: doc-min-dependencies Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.72%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +3.27% compared to 6ee390d
Details
scikit-learn.scikit-learn Build #20190915.12 succeeded
Details
scikit-learn.scikit-learn (Linux py35_conda_openblas) Linux py35_conda_openblas succeeded
Details
scikit-learn.scikit-learn (Linux py35_ubuntu_atlas) Linux py35_ubuntu_atlas succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_pip_openblas_pandas) Linux pylatest_pip_openblas_pandas succeeded
Details
scikit-learn.scikit-learn (Linux32 py35_ubuntu_atlas_32bit) Linux32 py35_ubuntu_atlas_32bit succeeded
Details
scikit-learn.scikit-learn (Windows py35_pip_openblas_32bit) Windows py35_pip_openblas_32bit succeeded
Details
scikit-learn.scikit-learn (Windows py37_conda_mkl) Windows py37_conda_mkl succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda_mkl) macOS pylatest_conda_mkl succeeded
Details
@NicolasHug NicolasHug deleted the NicolasHug:outputs_2d_dep_dummy branch Sep 15, 2019
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.