Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EHN update lobpcg from scipy master #14971

Merged
merged 3 commits into from Sep 16, 2019
Merged

Conversation

@glemaitre
Copy link
Contributor

glemaitre commented Sep 12, 2019

The version of lobpcg in scipy has recently benefited from some bug fixes.
We should update the version that we have in master.

glemaitre added 3 commits Sep 12, 2019
@ogrisel

This comment has been minimized.

Copy link
Member

ogrisel commented Sep 13, 2019

LGTM but maybe we should add a non-regression test for the bugs that are fixed by this backport?

Copy link
Member

ogrisel left a comment

The non-regression test is not mandatory: it's better to keep in sync than not anyway as I assume scipy has its own tests and I do not want to delay this PR.

@glemaitre

This comment has been minimized.

Copy link
Contributor Author

glemaitre commented Sep 13, 2019

The non-regression test is not mandatory: it's better to keep in sync than not anyway as I assume scipy has its own tests and I do not want to delay this PR.

+1 on this. If we see any additional thing to test, we should make it upstream.

@rth
rth approved these changes Sep 16, 2019
Copy link
Member

rth left a comment

LGTM.

@rth rth changed the title [MRG] EHN update lobpcg from scipy master EHN update lobpcg from scipy master Sep 16, 2019
@rth rth merged commit 2e8ce31 into scikit-learn:master Sep 16, 2019
18 checks passed
18 checks passed
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: doc Your tests passed on CircleCI!
Details
ci/circleci: doc artifact Link to 0/doc/_changed.html
Details
ci/circleci: doc-min-dependencies Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.7%)
Details
codecov/project 96.71% (+0.01%) compared to a8f2c98
Details
scikit-learn.scikit-learn Build #20190913.10 succeeded
Details
scikit-learn.scikit-learn (Linux py35_conda_openblas) Linux py35_conda_openblas succeeded
Details
scikit-learn.scikit-learn (Linux py35_ubuntu_atlas) Linux py35_ubuntu_atlas succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_pip_openblas_pandas) Linux pylatest_pip_openblas_pandas succeeded
Details
scikit-learn.scikit-learn (Linux32 py35_ubuntu_atlas_32bit) Linux32 py35_ubuntu_atlas_32bit succeeded
Details
scikit-learn.scikit-learn (Windows py35_pip_openblas_32bit) Windows py35_pip_openblas_32bit succeeded
Details
scikit-learn.scikit-learn (Windows py37_conda_mkl) Windows py37_conda_mkl succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda_mkl) macOS pylatest_conda_mkl succeeded
Details
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Sep 16, 2019
@jnothman jnothman mentioned this pull request Oct 28, 2019
0 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.