Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EHN update lobpcg from scipy master #14971

Merged
merged 3 commits into from Sep 16, 2019
Merged

Conversation

glemaitre
Copy link
Contributor

@glemaitre glemaitre commented Sep 12, 2019

The version of lobpcg in scipy has recently benefited from some bug fixes.
We should update the version that we have in master.

@ogrisel
Copy link
Member

@ogrisel ogrisel commented Sep 13, 2019

LGTM but maybe we should add a non-regression test for the bugs that are fixed by this backport?

Copy link
Member

@ogrisel ogrisel left a comment

The non-regression test is not mandatory: it's better to keep in sync than not anyway as I assume scipy has its own tests and I do not want to delay this PR.

@glemaitre
Copy link
Contributor Author

@glemaitre glemaitre commented Sep 13, 2019

The non-regression test is not mandatory: it's better to keep in sync than not anyway as I assume scipy has its own tests and I do not want to delay this PR.

+1 on this. If we see any additional thing to test, we should make it upstream.

rth
rth approved these changes Sep 16, 2019
Copy link
Member

@rth rth left a comment

LGTM.

@rth rth changed the title [MRG] EHN update lobpcg from scipy master EHN update lobpcg from scipy master Sep 16, 2019
@rth rth merged commit 2e8ce31 into scikit-learn:master Sep 16, 2019
18 checks passed
glemaitre added a commit to glemaitre/scikit-learn that referenced this issue Sep 16, 2019
@jnothman jnothman mentioned this pull request Oct 28, 2019
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants