Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: dtype check in MultiTaskLassoCV and MultiTaskLassoCV #15086

Merged

Conversation

@agramfort
Copy link
Member

agramfort commented Sep 24, 2019

closes #15081

@agramfort agramfort force-pushed the agramfort:fix_dtype_int_MultiTaskLassoCV branch from 82d3157 to 69fead3 Sep 24, 2019
@rth
rth approved these changes Sep 25, 2019
Copy link
Member

rth left a comment

Minor comment, LGTM otherwise.

def test_multi_task_lasso_cv_dtype():
n_samples, n_features = 10, 3
rng = np.random.RandomState(42)
X = rng.binomial(1, .5, size=(n_samples, n_features))

This comment has been minimized.

Copy link
@rth

rth Sep 25, 2019

Member

It's not necessarily clear to me while reading this that it would return a dtype int. Maybe worth, explicitly casting to int for readability,

Suggested change
X = rng.binomial(1, .5, size=(n_samples, n_features))
X = rng.binomial(1, .5, size=(n_samples, n_features)).astype(np.int)

This comment has been minimized.

Copy link
@agramfort

agramfort Sep 25, 2019

Author Member

done below.

Copy link
Member

GaelVaroquaux left a comment

LGTM.

@GaelVaroquaux

This comment has been minimized.

Copy link
Member

GaelVaroquaux commented Sep 26, 2019

Merging.

@GaelVaroquaux GaelVaroquaux merged commit d92f12a into scikit-learn:master Sep 26, 2019
19 checks passed
19 checks passed
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: doc Your tests passed on CircleCI!
Details
ci/circleci: doc artifact Link to 0/doc/_changed.html
Details
ci/circleci: doc-min-dependencies Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.76%)
Details
codecov/project 96.76% (+<.01%) compared to 21fc1d9
Details
scikit-learn.scikit-learn Build #20190925.7 succeeded
Details
scikit-learn.scikit-learn (Linux py35_conda_openblas) Linux py35_conda_openblas succeeded
Details
scikit-learn.scikit-learn (Linux py35_ubuntu_atlas) Linux py35_ubuntu_atlas succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_conda_mkl) Linux pylatest_conda_mkl succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_pip_openblas_pandas) Linux pylatest_pip_openblas_pandas succeeded
Details
scikit-learn.scikit-learn (Linux32 py35_ubuntu_atlas_32bit) Linux32 py35_ubuntu_atlas_32bit succeeded
Details
scikit-learn.scikit-learn (Windows py35_pip_openblas_32bit) Windows py35_pip_openblas_32bit succeeded
Details
scikit-learn.scikit-learn (Windows py37_conda_mkl) Windows py37_conda_mkl succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda_mkl) macOS pylatest_conda_mkl succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.