[MRG] Fixed n_support_ attr for OneClassSVM and SVR #15099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I mean it's better but ideally we'd fix that nonsense as well, right? |
|
that means we need a deprecation then. On master |
|
I would argue it's a bugfix. On master it's uninitialized memory values afaik. |
adrinjalali
reviewed
Sep 30, 2019
sklearn/svm/base.py
Outdated
| @@ -484,6 +484,17 @@ def coef_(self): | |||
| def _get_coef(self): | |||
| return safe_sparse_dot(self._dual_coef_, self.support_vectors_) | |||
|
|
|||
| @property | |||
| def n_support_(self): | |||
| check_is_fitted(self) | |||
There was a problem hiding this comment.
I think a @property raising a NotFittedError is kinda odd. Rather have an AttributeError here.
adrinjalali
reviewed
Oct 1, 2019
jnothman
approved these changes
Oct 2, 2019
sklearn/svm/libsvm.pyx
Outdated
| cdef np.ndarray[np.int32_t, ndim=1, mode='c'] n_class_SV | ||
| n_class_SV = np.empty(n_class, dtype=np.int32) | ||
| copy_nSV(n_class_SV.data, model) | ||
| if (svm_type == 0 or svm_type == 1): |
|
Comments were addressed, mergning. Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Closes #14799
Closes #15034
Fixes #14774
@amueller I think this is enough?
(That doesn't fix the nonsense that the attribute has size 2 (i.e. 2 classes) for OneClass and SVR but that's a different issue)It does now