Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[MRG] Fixed n_support_ attr for OneClassSVM and SVR #15099
Merged
+53
−12
Conversation
This comment has been minimized.
This comment has been minimized.
|
I mean it's better but ideally we'd fix that nonsense as well, right? |
This comment has been minimized.
This comment has been minimized.
|
that means we need a deprecation then. On master |
This comment has been minimized.
This comment has been minimized.
|
I would argue it's a bugfix. On master it's uninitialized memory values afaik. |
|
Otherwise LGTM :) |
sklearn/svm/base.py
Outdated
| @@ -484,6 +484,17 @@ def coef_(self): | |||
| def _get_coef(self): | |||
| return safe_sparse_dot(self._dual_coef_, self.support_vectors_) | |||
|
|
|||
| @property | |||
| def n_support_(self): | |||
| check_is_fitted(self) | |||
This comment has been minimized.
This comment has been minimized.
adrinjalali
Sep 30, 2019
Member
I think a @property raising a NotFittedError is kinda odd. Rather have an AttributeError here.
|
Thanks @NicolasHug |
|
Otherwise lgtm |
sklearn/svm/libsvm.pyx
Outdated
| cdef np.ndarray[np.int32_t, ndim=1, mode='c'] n_class_SV | ||
| n_class_SV = np.empty(n_class, dtype=np.int32) | ||
| copy_nSV(n_class_SV.data, model) | ||
| if (svm_type == 0 or svm_type == 1): |
This comment has been minimized.
This comment has been minimized.
NicolasHug
merged commit af82929
into
scikit-learn:master
19 checks passed
19 checks passed
scikit-learn.scikit-learn (Linux pylatest_pip_openblas_pandas)
Linux pylatest_pip_openblas_pandas succeeded
Details
scikit-learn.scikit-learn (Linux32 py35_ubuntu_atlas_32bit)
Linux32 py35_ubuntu_atlas_32bit succeeded
Details
scikit-learn.scikit-learn (Windows py35_pip_openblas_32bit)
Windows py35_pip_openblas_32bit succeeded
Details
This comment has been minimized.
This comment has been minimized.
|
Comments were addressed, mergning. Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
NicolasHug commentedSep 26, 2019
•
edited
Closes #14799
Closes #15034
Fixes #14774
@amueller I think this is enough?
(That doesn't fix the nonsense that the attribute has size 2 (i.e. 2 classes) for OneClass and SVR but that's a different issue)It does now