Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX add fit_params to FeatureUnion.fit #15119

Merged
merged 4 commits into from Oct 2, 2019

Conversation

@adrinjalali
Copy link
Member

adrinjalali commented Oct 2, 2019

Fixes #15117.

Adds fit_params to FeatureUnion.fit

adrinjalali added 2 commits Oct 2, 2019
Copy link
Member

jnothman left a comment

Sure, let's do this. Thanks

# Regression test for issue: #15117
class Dummy(TransformerMixin, BaseEstimator):
def fit(self, X, y=None, **fit_params):
if not fit_params:

This comment has been minimized.

Copy link
@jnothman

jnothman Oct 2, 2019

Member

let's check its name and value?

@adrinjalali adrinjalali changed the title FIX add fit_params to FeatureUnion.fit [MRG] FIX add fit_params to FeatureUnion.fit Oct 2, 2019
return X

X, y = iris.data, iris.target
t = FeatureUnion([('dummy', Dummy())])

This comment has been minimized.

Copy link
@thomasjpfan

thomasjpfan Oct 2, 2019

Member

Nit: FeatureUnion with two dummies?

Copy link
Contributor

tirthasheshpatel left a comment

Nice!

@thomasjpfan thomasjpfan changed the title [MRG] FIX add fit_params to FeatureUnion.fit FIX add fit_params to FeatureUnion.fit Oct 2, 2019
@thomasjpfan thomasjpfan merged commit 76d5f06 into scikit-learn:master Oct 2, 2019
19 checks passed
19 checks passed
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: doc Your tests passed on CircleCI!
Details
ci/circleci: doc artifact Link to 0/doc/_changed.html
Details
ci/circleci: doc-min-dependencies Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.77%)
Details
codecov/project Absolute coverage decreased by -0.03% but relative coverage increased by +3.22% compared to 4ca6ee4
Details
scikit-learn.scikit-learn Build #20191002.36 succeeded
Details
scikit-learn.scikit-learn (Linux py35_conda_openblas) Linux py35_conda_openblas succeeded
Details
scikit-learn.scikit-learn (Linux py35_ubuntu_atlas) Linux py35_ubuntu_atlas succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_conda_mkl) Linux pylatest_conda_mkl succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_pip_openblas_pandas) Linux pylatest_pip_openblas_pandas succeeded
Details
scikit-learn.scikit-learn (Linux32 py35_ubuntu_atlas_32bit) Linux32 py35_ubuntu_atlas_32bit succeeded
Details
scikit-learn.scikit-learn (Windows py35_pip_openblas_32bit) Windows py35_pip_openblas_32bit succeeded
Details
scikit-learn.scikit-learn (Windows py37_conda_mkl) Windows py37_conda_mkl succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda_mkl) macOS pylatest_conda_mkl succeeded
Details
@adrinjalali adrinjalali deleted the adrinjalali:fix/fu-fit branch Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.