Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX add max_iter, and func uses class #15120

Merged
merged 3 commits into from Oct 4, 2019
Merged

Conversation

adrinjalali
Copy link
Member

@adrinjalali adrinjalali commented Oct 2, 2019

Fixes #14995.

mean_shift uses MeanShift, and MeanShift has a max_iter now.

@adrinjalali adrinjalali requested a review from NicolasHug Oct 2, 2019
Copy link
Member

@NicolasHug NicolasHug left a comment

Looks like you need to set a n_iter_ attribute now, but LGTM

Thanks Adrin

@adrinjalali
Copy link
Member Author

@adrinjalali adrinjalali commented Oct 2, 2019

haha, I love our tests.

Copy link
Member

@NicolasHug NicolasHug left a comment

LGTM if all goes green

@adrinjalali adrinjalali changed the title FIX add max_iter, and func uses class [MRG] FIX add max_iter, and func uses class Oct 2, 2019
sklearn/cluster/tests/test_mean_shift.py Show resolved Hide resolved
sklearn/cluster/mean_shift_.py Outdated Show resolved Hide resolved
sklearn/cluster/mean_shift_.py Outdated Show resolved Hide resolved
@adrinjalali
Copy link
Member Author

@adrinjalali adrinjalali commented Oct 4, 2019

Thanks @thomasjpfan, all green.

rth
rth approved these changes Oct 4, 2019
Copy link
Member

@rth rth left a comment

LGTM. Thanks @adrinjalali !

@rth rth changed the title [MRG] FIX add max_iter, and func uses class FIX add max_iter, and func uses class Oct 4, 2019
@rth rth merged commit ac72a48 into scikit-learn:master Oct 4, 2019
19 checks passed
@NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Oct 4, 2019

Sorry didn't check before.. we can't change the commit message right? it doesn't mention mean_shift...

@rth
Copy link
Member

@rth rth commented Oct 4, 2019

I should have checked. No we can't short of rewriting history. Anyway commit message is not that critical history on that file and git blame would still work...

@adrinjalali adrinjalali deleted the mnt/meanshift branch Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants