Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Adds target names to fetch_openml #15160

Merged
merged 2 commits into from Oct 16, 2019

Conversation

thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Oct 8, 2019

Adds target_names into bunch returned by fetch_openml. The target name when target='default-target' is useful to have.

@@ -592,6 +592,8 @@ def fetch_openml(name=None, version='active', data_id=None, data_home=None,
The full description of the dataset
feature_names : list
The names of the dataset columns
target_names: list
The names of the target columns
Copy link
Member

@rth rth Oct 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a .. versionadded:: and a what's new entry.

rth
rth approved these changes Oct 14, 2019
Copy link
Member

@rth rth left a comment

LGTM, otherwise.

@rth rth merged commit 323cb61 into scikit-learn:master Oct 16, 2019
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants