Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Adds target names to fetch_openml #15160

Merged
merged 2 commits into from Oct 16, 2019

Conversation

@thomasjpfan
Copy link
Member

thomasjpfan commented Oct 8, 2019

Adds target_names into bunch returned by fetch_openml. The target name when target='default-target' is useful to have.

@@ -592,6 +592,8 @@ def fetch_openml(name=None, version='active', data_id=None, data_home=None,
The full description of the dataset
feature_names : list
The names of the dataset columns
target_names: list
The names of the target columns

This comment has been minimized.

Copy link
@rth

rth Oct 14, 2019

Member

Please add a .. versionadded:: and a what's new entry.

@rth
rth approved these changes Oct 14, 2019
Copy link
Member

rth left a comment

LGTM, otherwise.

@rth rth merged commit 323cb61 into scikit-learn:master Oct 16, 2019
19 checks passed
19 checks passed
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: doc Your tests passed on CircleCI!
Details
ci/circleci: doc artifact Link to 0/doc/_changed.html
Details
ci/circleci: doc-min-dependencies Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 95.99%)
Details
codecov/project 96.87% (+0.87%) compared to 6a8b3d4
Details
scikit-learn.scikit-learn Build #20191015.46 succeeded
Details
scikit-learn.scikit-learn (Linux py35_conda_openblas) Linux py35_conda_openblas succeeded
Details
scikit-learn.scikit-learn (Linux py35_ubuntu_atlas) Linux py35_ubuntu_atlas succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_conda_mkl) Linux pylatest_conda_mkl succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_pip_openblas_pandas) Linux pylatest_pip_openblas_pandas succeeded
Details
scikit-learn.scikit-learn (Linux32 py35_ubuntu_atlas_32bit) Linux32 py35_ubuntu_atlas_32bit succeeded
Details
scikit-learn.scikit-learn (Windows py35_pip_openblas_32bit) Windows py35_pip_openblas_32bit succeeded
Details
scikit-learn.scikit-learn (Windows py37_conda_mkl) Windows py37_conda_mkl succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda_mkl) macOS pylatest_conda_mkl succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.