StratifiedGroupShuffleSplit and StratifiedGroupKFold #15239
Conversation
|
Could you please add tests @hermidalc ;) |
| folds are made by preserving the percentage of groups for each class. | ||
|
|
||
| Note: like the StratifiedShuffleSplit strategy, stratified random group | ||
| splits do not guarantee that all folds will be different, although this is |
There was a problem hiding this comment.
I don't understand this sentence. What do you mean by "folds not being different"?
There was a problem hiding this comment.
That text is copied from StratifiedShuffleSplit and the meaning behind it is that shuffle splitting does not guarantee that each split will be different than another.
There was a problem hiding this comment.
Ah. I think in sklearn we call folds the partitions in the split, not the repetitions.
There was a problem hiding this comment.
I think partitions/splits/folds that's what is meant here and I believe in StratifiedShuffleSplit. With randomized splits there is no guarantee that a partition will be different than other ones.
hermidalc
changed the title
|
Hey @hermidalc, any update on this? |
|
Can we get tests by any chance, @hermidalc? |
See reply in #13621 |
|
closed by #18649 |
This implements a Stratified version of the GroupShuffleSplit and GroupKFold cross-validators. Note that GroupKFold differs from StratifiedGroupKFold in that GroupKFold attempts to approximately balance the number of groups in each fold regardless of group class, whereas StratifiedGroupKFold attempts to stratify the group class percentages in each fold to be the same as that of the entire data.
There are two important points regarding the implementation logic:
This makes the logic straightforward and covers a lot of use cases (at least the ones I needed them for in my work).
TODO: