Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX a bug where ascending and descending were inverted #15393

Merged
merged 10 commits into from Nov 6, 2019

Conversation

@venkyyuvy
Copy link
Contributor

venkyyuvy commented Oct 29, 2019

Reference Issues/PRs: Fixes #15372

What does this implement/fix? Explain your changes.

swaped the ordering logic for ascending and descending ordering option.

@jnothman

This comment has been minimized.

Copy link
Member

jnothman commented Oct 29, 2019

This breaks existing tests, it seems, and we would do well to have a test which ensures this behaviour

@jnothman

This comment has been minimized.

Copy link
Member

jnothman commented Oct 30, 2019

Please add a test which checks that the correct order is used.

@adrinjalali

This comment has been minimized.

Copy link
Member

adrinjalali commented Nov 4, 2019

Added a test and a whats_new entry. @venkyyuvy you'll need to do a git pull before you do any changes now :)

@adrinjalali

This comment has been minimized.

Copy link
Member

adrinjalali commented Nov 5, 2019

O_o the iterative imputer fails to warn on rare occasions after one iteration? This needs some investigation

@venkyyuvy

This comment has been minimized.

Copy link
Contributor Author

venkyyuvy commented Nov 5, 2019

Added a test and a whats_new entry. @venkyyuvy you'll need to do a git pull before you do any changes now :)

You are amazing man! Thanks a lot.

Now I am feeling guilty to put my name for this bug fix. Can I add your name as well in the wats_new?

I have added a random seed, to see if it fixes the warning issue.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #15393 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15393      +/-   ##
==========================================
+ Coverage   97.16%   97.16%   +<.01%     
==========================================
  Files         391      391              
  Lines       76858    76870      +12     
  Branches     8305     8306       +1     
==========================================
+ Hits        74680    74693      +13     
  Misses       2168     2168              
+ Partials       10        9       -1
Impacted Files Coverage Δ
sklearn/impute/_iterative.py 98.51% <ø> (ø) ⬆️
sklearn/impute/tests/test_impute.py 99.66% <100%> (ø) ⬆️
sklearn/manifold/_mds.py 94.11% <0%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ac3fd...58deffb. Read the comment docs.

doc/whats_new/v0.22.rst Outdated Show resolved Hide resolved
@jnothman jnothman changed the title Fixing the sorting order bug FIX a bug where ascending and descending were inverted Nov 6, 2019
@jnothman

This comment has been minimized.

Copy link
Member

jnothman commented Nov 6, 2019

Thanks @venkyyuvy

@jnothman jnothman merged commit c96e095 into scikit-learn:master Nov 6, 2019
20 checks passed
20 checks passed
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python 8 new alerts
Details
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: doc Your tests passed on CircleCI!
Details
ci/circleci: doc artifact Link to 0/doc/_changed.html
Details
ci/circleci: doc-min-dependencies Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 97.16%)
Details
codecov/project Absolute coverage decreased by -1.04% but relative coverage increased by +2.83% compared to 37ac3fd
Details
scikit-learn.scikit-learn Build #20191106.49 succeeded
Details
scikit-learn.scikit-learn (Linting) Linting succeeded
Details
scikit-learn.scikit-learn (Linux py35_conda_openblas) Linux py35_conda_openblas succeeded
Details
scikit-learn.scikit-learn (Linux py35_ubuntu_atlas) Linux py35_ubuntu_atlas succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_pip_openblas_pandas) Linux pylatest_pip_openblas_pandas succeeded
Details
scikit-learn.scikit-learn (Linux32 py35_ubuntu_atlas_32bit) Linux32 py35_ubuntu_atlas_32bit succeeded
Details
scikit-learn.scikit-learn (Linux_Runs pylatest_conda_mkl) Linux_Runs pylatest_conda_mkl succeeded
Details
scikit-learn.scikit-learn (Windows py35_pip_openblas_32bit) Windows py35_pip_openblas_32bit succeeded
Details
scikit-learn.scikit-learn (Windows py37_conda_mkl) Windows py37_conda_mkl succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda_mkl) macOS pylatest_conda_mkl succeeded
Details
@venkyyuvy venkyyuvy deleted the venkyyuvy:imputer_order branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.