New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX a bug where ascending and descending were inverted #15393
Conversation
This breaks existing tests, it seems, and we would do well to have a test which ensures this behaviour |
Please add a test which checks that the correct order is used. |
Added a test and a whats_new entry. @venkyyuvy you'll need to do a |
O_o the iterative imputer fails to warn on rare occasions after one iteration? This needs some investigation |
You are amazing man! Thanks a lot. Now I am feeling guilty to put my name for this bug fix. Can I add your name as well in the I have added a random seed, to see if it fixes the warning issue. |
Codecov Report
@@ Coverage Diff @@
## master #15393 +/- ##
==========================================
+ Coverage 97.16% 97.16% +<.01%
==========================================
Files 391 391
Lines 76858 76870 +12
Branches 8305 8306 +1
==========================================
+ Hits 74680 74693 +13
Misses 2168 2168
+ Partials 10 9 -1
Continue to review full report at Codecov.
|
Thanks @venkyyuvy |
Reference Issues/PRs: Fixes #15372
What does this implement/fix? Explain your changes.
swaped the ordering logic for
ascending
anddescending
ordering option.