Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

property for predict_proba in MultiOutput Classifier #15490

Merged
merged 5 commits into from Nov 7, 2019
Merged

property for predict_proba in MultiOutput Classifier #15490

merged 5 commits into from Nov 7, 2019

Conversation

rebekahkim
Copy link
Contributor

Reference Issues/PRs

Fixes #15488. See also #12222.

What does this implement/fix? Explain your changes.

Have predict_proba as a property of MultiOutputClassifier.

@amueller amueller changed the title property for predict_proba property for predict_proba in MultiOutput Classifier Nov 2, 2019
amueller
amueller reviewed Nov 2, 2019
View reviewed changes
sklearn/multioutput.py Outdated Show resolved Hide resolved
NicolasHug
NicolasHug reviewed Nov 4, 2019
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @rebekahkim , made a few comments but looks good

sklearn/tests/test_multioutput.py Outdated Show resolved Hide resolved
sklearn/tests/test_multioutput.py Outdated Show resolved Hide resolved
sklearn/multioutput.py Outdated Show resolved Hide resolved
@jnothman
Copy link
Member

jnothman commented Nov 7, 2019

Please add a|Fix| entry to the change log at doc/whats_new/v0.22.rst. Like the other entries there, please reference this pull request with :pr: and credit yourself (and other contributors if applicable) with :user:

NicolasHug
NicolasHug approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when what's new entry is added ;)

Thanks @rebekahkim

@jnothman jnothman merged commit 981fa7b into scikit-learn:master Nov 7, 2019
@jnothman
Copy link
Member

jnothman commented Nov 7, 2019

Thank you!

@rebekahkim rebekahkim deleted the mo-predict_proba-attr branch November 7, 2019 22:45
@amueller
Copy link
Member

amueller commented Nov 8, 2019

Sweet, congrats :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@NicolasHug NicolasHug NicolasHug approved these changes

@amueller amueller Awaiting requested review from amueller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MultiOutputClassifier has predict_proba attribute for base classifiers without predict_proba
4 participants
@rebekahkim @jnothman @amueller @NicolasHug