Skip to content

/ scikit-learn

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

property for predict_proba in MultiOutput Classifier #15490

Merged
merged 5 commits into from Nov 7, 2019
Merged

property for predict_proba in MultiOutput Classifier #15490

merged 5 commits into from Nov 7, 2019

Conversation

@rebekahkim
Copy link
Contributor

rebekahkim commented Nov 2, 2019

Reference Issues/PRs

Fixes #15488. See also #12222.

What does this implement/fix? Explain your changes.

Have predict_proba as a property of MultiOutputClassifier.
@rebekahkim
property for predict_proba
Verified
This commit was signed with a verified signature.
rebekahkim Rebekah Kim
GPG key ID: 9D703FE3893AF966 Learn about signing commits
Loading status checks…
c4220ea
@amueller amueller changed the title property for predict_proba property for predict_proba in MultiOutput Classifier Nov 2, 2019
@amueller
amueller reviewed Nov 2, 2019
View changes
sklearn/multioutput.py Outdated Show resolved Hide resolved
@amueller
amueller reviewed Nov 2, 2019
View changes
sklearn/tests/test_multioutput.py Outdated Show resolved Hide resolved
rebekahkim added 2 commits Nov 4, 2019
@rebekahkim
address review comments
Verified
This commit was signed with a verified signature.
rebekahkim Rebekah Kim
GPG key ID: 9D703FE3893AF966 Learn about signing commits
Loading status checks…
b46ffb0
@rebekahkim
flake8 lint
Verified
This commit was signed with a verified signature.
rebekahkim Rebekah Kim
GPG key ID: 9D703FE3893AF966 Learn about signing commits
Loading status checks…
cb9a677
@NicolasHug
NicolasHug reviewed Nov 4, 2019
View changes
Copy link
Contributor

NicolasHug left a comment

Thanks for the PR @rebekahkim , made a few comments but looks good
sklearn/tests/test_multioutput.py Outdated Show resolved Hide resolved
sklearn/tests/test_multioutput.py Outdated Show resolved Hide resolved
sklearn/multioutput.py Outdated Show resolved Hide resolved
@rebekahkim
address review
Verified
This commit was signed with a verified signature.
rebekahkim Rebekah Kim
GPG key ID: 9D703FE3893AF966 Learn about signing commits
Loading status checks…
8911c13
@rebekahkim rebekahkim requested review from NicolasHug and amueller Nov 4, 2019
@jnothman
jnothman approved these changes Nov 7, 2019
View changes
@jnothman

This comment has been minimized.

Sign in to view
Copy link
Member

jnothman commented Nov 7, 2019

Please add a|Fix| entry to the change log at doc/whats_new/v0.22.rst. Like the other entries there, please reference this pull request with :pr: and credit yourself (and other contributors if applicable) with :user:
@NicolasHug
NicolasHug approved these changes Nov 7, 2019
View changes
Copy link
Contributor

NicolasHug left a comment

LGTM when what's new entry is added ;)

Thanks @rebekahkim
@rebekahkim
doc entry
Verified
This commit was signed with a verified signature.
rebekahkim Rebekah Kim
GPG key ID: 9D703FE3893AF966 Learn about signing commits
Loading status checks…
13cacac
@jnothman jnothman merged commit 981fa7b into scikit-learn:master Nov 7, 2019
16 of 18 checks passed
16 of 18 checks passed
ci/circleci: doc Your tests are queued behind your running builds
Details
ci/circleci: doc-min-dependencies Your tests are queued behind your running builds
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.11%)
Details
codecov/project 97.16% (+1.05%) compared to 51edab8
Details
scikit-learn.scikit-learn Build #20191107.61 succeeded
Details
scikit-learn.scikit-learn (Linting) Linting succeeded
Details
scikit-learn.scikit-learn (Linux py35_conda_openblas) Linux py35_conda_openblas succeeded
Details
scikit-learn.scikit-learn (Linux py35_ubuntu_atlas) Linux py35_ubuntu_atlas succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_pip_openblas_pandas) Linux pylatest_pip_openblas_pandas succeeded
Details
scikit-learn.scikit-learn (Linux32 py35_ubuntu_atlas_32bit) Linux32 py35_ubuntu_atlas_32bit succeeded
Details
scikit-learn.scikit-learn (Linux_Runs pylatest_conda_mkl) Linux_Runs pylatest_conda_mkl succeeded
Details
scikit-learn.scikit-learn (Windows py35_pip_openblas_32bit) Windows py35_pip_openblas_32bit succeeded
Details
scikit-learn.scikit-learn (Windows py37_conda_mkl) Windows py37_conda_mkl succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda_mkl) macOS pylatest_conda_mkl succeeded
Details
@jnothman

This comment has been minimized.

Sign in to view
Copy link
Member

jnothman commented Nov 7, 2019

Thank you!
@rebekahkim rebekahkim deleted the rebekahkim:mo-predict_proba-attr branch Nov 7, 2019
@amueller

This comment has been minimized.

Sign in to view
Copy link
Member

amueller commented Nov 8, 2019

Sweet, congrats :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman

@NicolasHug NicolasHug

@amueller amueller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@rebekahkim @jnothman @amueller @NicolasHug
You can’t perform that action at this time.