Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG + 2] add pairwise property to basesearchcv #15524

Conversation

xun-tang
Copy link
Contributor

@xun-tang xun-tang commented Nov 3, 2019

Reference Issues/PRs

Fixes #13920. Pulled from a stalled PR #13925.

What does this implement/fix? Explain your changes.

  • Address the all comments from @NicolasHug on #13925
    -- use GridSearchCV not creating a dummy class for test.
    -- docstring changes
  • Split the test to two separate tests since they test different
    aspects of the functionality.

Any other comments?

My first non-documentation PR on sklearn. Comments welcome.

jnothman
Copy link
Member

@jnothman jnothman commented on 2546ef9 May 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when the attribute name is const, you should just use est._pairwise = ...

jnothman
Copy link
Member

@jnothman jnothman commented on 2546ef9 May 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verity -> verify

eyes-robson
Copy link

@eyes-robson eyes-robson commented on 2546ef9 May 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that would be a bit simpler

Copy link
Member

@NicolasHug NicolasHug left a comment

Thanks @xun-tang , just a few comments but LGTM

doc/whats_new/v0.22.rst Show resolved Hide resolved
sklearn/model_selection/tests/test_search.py Show resolved Hide resolved
sklearn/model_selection/tests/test_search.py Show resolved Hide resolved
@xun-tang xun-tang changed the title [MRG] add pairwise property to basesearchcv [MRG + 2] add pairwise property to basesearchcv Nov 6, 2019
@cmarmo
Copy link
Member

@cmarmo cmarmo commented Nov 10, 2019

@jnothman , @NicolasHug if you are happy with the changes, this one could be merge?

@jnothman jnothman merged commit 3ef8357 into scikit-learn:master Nov 10, 2019
20 checks passed
@jnothman
Copy link
Member

@jnothman jnothman commented Nov 10, 2019

Thanks @xun-tang

@xun-tang xun-tang deleted the xun-13925-add_pairwise_property_to_basesearchcv branch Nov 27, 2019
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this issue Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants