[MRG + 2] add pairwise property to basesearchcv #15524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
when the attribute name is const, you should just use est._pairwise = ...
There was a problem hiding this comment.
verity -> verify
There was a problem hiding this comment.
Yes, that would be a bit simpler
…arn into xun-13925-add_pairwise_property_to_basesearchcv_master
jnothman
approved these changes
Nov 4, 2019
xun-tang
changed the title
|
@jnothman , @NicolasHug if you are happy with the changes, this one could be merge? |
|
Thanks @xun-tang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Reference Issues/PRs
Fixes #13920. Pulled from a stalled PR #13925.
What does this implement/fix? Explain your changes.
-- use
GridSearchCVnot creating a dummy class for test.-- docstring changes
aspects of the functionality.
Any other comments?
My first non-documentation PR on sklearn. Comments welcome.