New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG + 2] add pairwise property to basesearchcv #15524
[MRG + 2] add pairwise property to basesearchcv #15524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when the attribute name is const, you should just use est._pairwise = ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verity -> verify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that would be a bit simpler
…arn into xun-13925-add_pairwise_property_to_basesearchcv_master
@jnothman , @NicolasHug if you are happy with the changes, this one could be merge? |
Thanks @xun-tang |
Reference Issues/PRs
Fixes #13920. Pulled from a stalled PR #13925.
What does this implement/fix? Explain your changes.
-- use
GridSearchCV
not creating a dummy class for test.-- docstring changes
aspects of the functionality.
Any other comments?
My first non-documentation PR on sklearn. Comments welcome.