FIX add best_score_ to Ridge*CV estimators #15655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
changed the title
|
Remove irrelevant things? I guess you're going to split that PR into multiple parts. |
|
@qinhanmin2014 OK, this should be easy to review now since there is only relevant information to be merged. |
|
@rth, @adrinjalali could you have a look at it as well. |
jnothman
reviewed
Dec 10, 2019
glemaitre
changed the title
qinhanmin2014
approved these changes
Dec 10, 2019
sklearn/linear_model/_ridge.py
Outdated
| @@ -1693,6 +1695,9 @@ class RidgeCV(MultiOutputMixin, RegressorMixin, _BaseRidgeCV): | |||
| alpha_ : float | |||
| Estimated regularization parameter. | |||
|
|
|||
| best_score_ : float | |||
| Score of base estimator with best alpha on the hold out data. | |||
There was a problem hiding this comment.
the version from GridSearchCV seems better: "Mean cross-validated score of the best_estimator"
There was a problem hiding this comment.
I changed the docstring. However, I don't refer to best_estimator because we don't have such attributes (while it is available in GridSearchCV).
rth
reviewed
Dec 10, 2019
| @@ -73,6 +73,10 @@ Changelog | |||
| `store_cv_values` is `True`. | |||
| :pr:`15652` by :user:`Jérôme Dockès <jeromedockes>`. | |||
|
|
|||
| - |Fix| add `best_score_` attribute to :class:`linear_model.RidgeCV` and | |||
| :class:`linear_model.RidgeClassifierCV`. | |||
| :pr:`15653` by :user:`Jérôme Dockès <jeromedockes>`. | |||
There was a problem hiding this comment.
it was originally @jeromedockes, I am just splitting the PR such that it is easy to review
rth
changed the title
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4667
closes #4790
Add
best_score_attribute in Ridge*CV.Build on #15652