-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
adding return_centers param #15709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding return_centers param #15709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @venkyyuvy , looks good.
This would need a what's new entry (in 0.23). Maybe we can also credit @shivamgargsya's work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments but LGTM when addressed
Please add an entry to the change log at doc/whats_new/v023.rst
. Like the other entries there, please reference this pull request with :pr:
and credit yourself (and other contributors if applicable) with :user:
.
…into return_center
Anyone for a quick review @jnothman @qinhanmin2014 @thomasjpfan ? The codecov can be ignored (changes are properly tested) |
Thanks @venkyyuvy! |
Reference Issues/PRs: Fixes #15684
What does this implement/fix? Explain your changes.
Added a param to return the centers of each cluster in
make_blobs
and added a test for it