Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding return_centers param #15709

Merged
merged 8 commits into from Jan 22, 2020
Merged

adding return_centers param #15709

merged 8 commits into from Jan 22, 2020

Conversation

venkyyuvy
Copy link
Contributor

@venkyyuvy venkyyuvy commented Nov 23, 2019 •
edited

Reference Issues/PRs: Fixes #15684

What does this implement/fix? Explain your changes.

Added a param to return the centers of each cluster in make_blobs and added a test for it

NicolasHug
NicolasHug reviewed Nov 26, 2019
View changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @venkyyuvy , looks good.

This would need a what's new entry (in 0.23). Maybe we can also credit @shivamgargsya's work

sklearn/datasets/_samples_generator.py Outdated Show resolved Hide resolved
sklearn/datasets/_samples_generator.py Outdated Show resolved Hide resolved
sklearn/datasets/_samples_generator.py Outdated Show resolved Hide resolved
sklearn/datasets/tests/test_samples_generator.py Outdated Show resolved Hide resolved
NicolasHug
NicolasHug approved these changes Dec 2, 2019
View changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments but LGTM when addressed

Please add an entry to the change log at doc/whats_new/v023.rst. Like the other entries there, please reference this pull request with :pr: and credit yourself (and other contributors if applicable) with :user:.

sklearn/datasets/_samples_generator.py Outdated Show resolved Hide resolved
sklearn/datasets/_samples_generator.py Show resolved Hide resolved
jnothman
jnothman reviewed Dec 7, 2019
View changes
doc/whats_new/v0.23.rst Outdated Show resolved Hide resolved
sklearn/datasets/_samples_generator.py Show resolved Hide resolved
@NicolasHug
Copy link
Member

Anyone for a quick review @jnothman @qinhanmin2014 @thomasjpfan ?

The codecov can be ignored (changes are properly tested)

@qinhanmin2014 qinhanmin2014 merged commit ac9c3e1 into scikit-learn:master Jan 22, 2020
@NicolasHug
Copy link
Member

Thanks @venkyyuvy!

thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Feb 22, 2020
@venkyyuvy @thomasjpfan
ENH adding return_centers param in make_blobs (scikit-learn#15709)
84d6d9d
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
@venkyyuvy @panpiort
ENH adding return_centers param in make_blobs (scikit-learn#15709)
cb4df62
@cmarmo cmarmo mentioned this pull request Jun 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman left review comments

@NicolasHug NicolasHug NicolasHug approved these changes

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add return_centers parameter to make_blobs
4 participants
@venkyyuvy @NicolasHug @jnothman @qinhanmin2014