adding return_centers param#15709
Merged
Merged
Conversation
NicolasHug
reviewed
Nov 26, 2019
Member
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks @venkyyuvy , looks good.
This would need a what's new entry (in 0.23). Maybe we can also credit @shivamgargsya's work
jnothman
reviewed
Dec 2, 2019
NicolasHug
approved these changes
Dec 2, 2019
Member
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
A few more comments but LGTM when addressed
Please add an entry to the change log at doc/whats_new/v023.rst. Like the other entries there, please reference this pull request with :pr: and credit yourself (and other contributors if applicable) with :user:.
jnothman
reviewed
Dec 7, 2019
…into return_center
NicolasHug
reviewed
Jan 12, 2020
Member
|
Anyone for a quick review @jnothman @qinhanmin2014 @thomasjpfan ? The codecov can be ignored (changes are properly tested) |
qinhanmin2014
approved these changes
Jan 22, 2020
Member
|
Thanks @venkyyuvy! |
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 22, 2020
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs: Fixes #15684
What does this implement/fix? Explain your changes.
Added a param to return the centers of each cluster in
make_blobsand added a test for it