New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate unused 'rotate' parameter in tree.plot_tree. #15806
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The small test would be along the line:
# FIXME: to be removed in 0.25
def test_plot_tree_rotate_deprecation():
# test that a warning is raised when rotate is used.
match = "The warning message"
with pytest.warns(FutureWarning, match=match):
plot_tree(..., rotate=True)
LGTM. We are just missing an entry in what's new 0.23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a missing pytest fixture to get the tests to pass on the CI:
Co-Authored-By: Olivier Grisel <olivier.grisel@ensta.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cmarmo
…arn#15806) * Deprecate unused 'rotate' parameter in tree.plot_tree. * Clarify warning and docstring. Add test. * Fix lint error and adress comment. * Fix python lint error. * Add what's new entry. Conform to skl convention. * Update sklearn/tree/tests/test_export.py Co-Authored-By: Olivier Grisel <olivier.grisel@ensta.org>
Reference Issues/PRs
Fixes #15694.
Originally reported in #13971.
What does this implement/fix? Explain your changes.
As suggested in the corresponding issue and on the discussion mailing list, the
rotate
parameter is deprecated. Will be removed in 0.25