Deprecate unused 'rotate' parameter in tree.plot_tree. #15806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
reviewed
Dec 5, 2019
adrinjalali
reviewed
Dec 5, 2019
glemaitre
reviewed
Dec 6, 2019
There was a problem hiding this comment.
The small test would be along the line:
# FIXME: to be removed in 0.25
def test_plot_tree_rotate_deprecation():
# test that a warning is raised when rotate is used.
match = "The warning message"
with pytest.warns(FutureWarning, match=match):
plot_tree(..., rotate=True)
|
LGTM. We are just missing an entry in what's new 0.23 |
glemaitre
reviewed
Dec 6, 2019
ogrisel
approved these changes
Dec 6, 2019
Co-Authored-By: Olivier Grisel <olivier.grisel@ensta.org>
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
…arn#15806) * Deprecate unused 'rotate' parameter in tree.plot_tree. * Clarify warning and docstring. Add test. * Fix lint error and adress comment. * Fix python lint error. * Add what's new entry. Conform to skl convention. * Update sklearn/tree/tests/test_export.py Co-Authored-By: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Reference Issues/PRs
Fixes #15694.
Originally reported in #13971.
What does this implement/fix? Explain your changes.
As suggested in the corresponding issue and on the discussion mailing list, the
rotateparameter is deprecated. Will be removed in 0.25