ENH Improve column_or_1d error message - #15926
Merged
thomasjpfan merged 3 commits intoDec 20, 2019
Merged
Conversation
rth
approved these changes
Dec 19, 2019
thomasjpfan
approved these changes
Dec 19, 2019
thomasjpfan
left a comment
thomasjpfan
left a comment
Member
There was a problem hiding this comment.
LGTM! Should this have a whats new entry in 0.23 under Enhancement?
Member
Author
|
Whats new entry added. |
Member
Author
|
Sorry misclick for the close/open |
thomasjpfan
approved these changes
Dec 20, 2019
thomasjpfan
changed the title
Member
|
Thank you @lesteve ! |
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My experience is that it is generally a good idea to state the expectation explicitly in the error message. Feel free to suggest a better error message.