Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Add verbose option to VotingClassifier and VotingRegre… #16069

Merged
merged 36 commits into from Jan 9, 2020

Conversation

cmarmo
Copy link
Member

@cmarmo cmarmo commented Jan 9, 2020

Reference Issues/PRs

Fixes #10360
If merged closes #14772, #15991, #10365, #10974

What does this implement/fix? Explain your changes.

Add a boolean verbose option to VotingClassifier and VotingRegressor.
Follows the example of #11364.

hannahbrucemacdonald and others added 30 commits August 24, 2019 10:57
Co-Authored-By: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-Authored-By: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-Authored-By: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@cmarmo cmarmo changed the title Reshamas voting Add verbose option to VotingClassifier and VotingRegressor Jan 9, 2020
@cmarmo
Copy link
Member Author

cmarmo commented Jan 9, 2020

@glemaitre this PR is meant to address your comments in #15991.... if CI agrees ...

@glemaitre glemaitre self-requested a review January 9, 2020 13:03
@glemaitre glemaitre changed the title Add verbose option to VotingClassifier and VotingRegressor [MRG+1] Add verbose option to VotingClassifier and VotingRegressor Jan 9, 2020
Copy link
Contributor

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It follows the same API as Pipeline, ColumnTransformer, and FeatureUnion.
@thomasjpfan If you can have a quick look. I think that we will be able to close a lot of redundant PRs.

sklearn/ensemble/_voting.py Outdated Show resolved Hide resolved
sklearn/ensemble/tests/test_voting.py Outdated Show resolved Hide resolved
sklearn/ensemble/tests/test_voting.py Outdated Show resolved Hide resolved
cmarmo and others added 3 commits January 9, 2020 19:29
Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>
Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>
Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>
@cmarmo
Copy link
Member Author

cmarmo commented Jan 9, 2020

I'm on the lint fix.

@thomasjpfan thomasjpfan changed the title [MRG+1] Add verbose option to VotingClassifier and VotingRegressor ENH Add verbose option to VotingClassifier and VotingRegre… Jan 9, 2020
@thomasjpfan thomasjpfan merged commit 5a02de8 into scikit-learn:master Jan 9, 2020
@jnothman
Copy link
Member

jnothman commented Jan 9, 2020

Thanks @cmarmo. To make a merge close multiple issues you need to repeat "closes" before each issue number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verbose VotingClassifier
6 participants