ENH Add verbose option to VotingClassifier and VotingRegre… #16069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssor addresses issue scikit-learn#10360
…ers to `_parallel_fit_estimator`.
Fix test errors for PR scikit-learn#15991
…into verbose_voting
Co-Authored-By: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-Authored-By: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-Authored-By: Guillaume Lemaitre <g.lemaitre58@gmail.com>
cmarmo
changed the title
|
@glemaitre this PR is meant to address your comments in #15991.... if CI agrees ... |
glemaitre
changed the title
glemaitre
approved these changes
Jan 9, 2020
There was a problem hiding this comment.
LGTM. It follows the same API as Pipeline, ColumnTransformer, and FeatureUnion.
@thomasjpfan If you can have a quick look. I think that we will be able to close a lot of redundant PRs.
thomasjpfan
reviewed
Jan 9, 2020
Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>
Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>
Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>
|
I'm on the lint fix. |
thomasjpfan
approved these changes
Jan 9, 2020
thomasjpfan
changed the title
|
Thanks @cmarmo. To make a merge close multiple issues you need to repeat "closes" before each issue number |
This was referenced Jan 9, 2020
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 22, 2020
jnothman
reviewed
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #10360
If merged closes #14772, #15991, #10365, #10974
What does this implement/fix? Explain your changes.
Add a boolean verbose option to
VotingClassifierandVotingRegressor.Follows the example of #11364.