Skip to content

[MRG] BUG Clips log_loss calculation in neural_network - #16117

Merged
ogrisel merged 5 commits into
scikit-learn:masterfrom
thomasjpfan:binary_log_loss_eps
Jan 15, 2020
Merged

ogrisel merged 5 commits into
scikit-learn:masterfrom
thomasjpfan:binary_log_loss_eps

Conversation

@thomasjpfan

Copy link
Copy Markdown
Member

Stumbled on this instability while reviewing a PR.

@rth

rth commented Jan 14, 2020

Copy link
Copy Markdown
Member

Linting fails, but LGTM assuming CI passes.

Worth mentioning that it's a similar clipping approach that the one use in sklearn.metrics.log_loss

@ogrisel ogrisel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as well. +1 for merge once documented in whats_new

@ogrisel
ogrisel merged commit d7c3758 into scikit-learn:master Jan 15, 2020
thomasjpfan added a commit to thomasjpfan/scikit-learn that referenced this pull request Feb 22, 2020
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants