-
-
Notifications
You must be signed in to change notification settings - Fork 25.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX Expose SelectorMixin through sklearn/feature_selection/ #16132
Conversation
Is this also missing from doc/modules/classes.rst |
OK, added, @jnothman. Are there other places where documentation should be changed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fine if the docstring of SelectorMixin is sufficiently informative
I didn't write the SelectorMixin docstring, but it's actually a bit more verbose than the docstrings on ClassifierMixin, TransformerMixin, RegressorMixin, etc. That said, comparing SelectorMixin with those other Mixins a little more closely, I notice that most define an _estimator_type property, while SelectorMixin does not. I don't know if that's an issue that needs to be addressed, and if so if this PR is the right place to address it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Not fully sure, but |
Reference Issues/PRs
Fixes #16126
What does this implement/fix? Explain your changes.
Any other comments?