FIX Expose SelectorMixin through sklearn/feature_selection/#16132
Conversation
|
Is this also missing from doc/modules/classes.rst |
|
OK, added, @jnothman. Are there other places where documentation should be changed? |
jnothman
left a comment
There was a problem hiding this comment.
This should be fine if the docstring of SelectorMixin is sufficiently informative
|
I didn't write the SelectorMixin docstring, but it's actually a bit more verbose than the docstrings on ClassifierMixin, TransformerMixin, RegressorMixin, etc. That said, comparing SelectorMixin with those other Mixins a little more closely, I notice that most define an _estimator_type property, while SelectorMixin does not. I don't know if that's an issue that needs to be addressed, and if so if this PR is the right place to address it. |
Not fully sure, but |
Reference Issues/PRs
Fixes #16126
What does this implement/fix? Explain your changes.
Any other comments?