/ scikit-learn Public
FIX support read only view for tree input #16331
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
What does this implement/fix? Explain your changes.
According to https://cython.readthedocs.io/en/latest/src/userguide/memoryviews.html#read-only-views
This should be fine with scikit-learn since the minimal Cython version supported is 28.5. We could also check the input array for the
writeableflag and make a copy instead of a view if needed but I figured this solution would be better.
Any other comments?
The benchmarks now work as expected.
2020 Paris Sprint