BUG Clips mutual_info_score below - #16362
Merged
rth merged 5 commits intoFeb 2, 2020
Merged
Conversation
thomasjpfan
changed the title
jnothman
approved these changes
Feb 1, 2020
jnothman
left a comment
jnothman
left a comment
Member
There was a problem hiding this comment.
Lgtm though I've not checked the test fails at master
Member
|
What's new? |
rth
approved these changes
Feb 2, 2020
rth
left a comment
rth
left a comment
Member
There was a problem hiding this comment.
LGTM as well once a what's new is added. Can confirm the test fails on master.
Member
|
Thanks @thomasjpfan ! |
rth
changed the title
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 22, 2020
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Resolves #16355
What does this implement/fix? Explain your changes.
Non-regression test that specifically targets the failing discrete case on master.
Any other comments?