Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG Clips mutual_info_score below #16362

Merged
merged 5 commits into from Feb 2, 2020

Conversation

thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Feb 1, 2020

Reference Issues/PRs

Resolves #16355

What does this implement/fix? Explain your changes.

Non-regression test that specifically targets the failing discrete case on master.

Any other comments?

@thomasjpfan thomasjpfan changed the title BUG Clips mutual_info_score below [MRG] BUG Clips mutual_info_score below Feb 1, 2020
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm though I've not checked the test fails at master

@jnothman
Copy link
Member

jnothman commented Feb 1, 2020

What's new?

Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well once a what's new is added. Can confirm the test fails on master.

@rth
Copy link
Member

rth commented Feb 2, 2020

Thanks @thomasjpfan !

@rth rth changed the title [MRG] BUG Clips mutual_info_score below BUG Clips mutual_info_score below Feb 2, 2020
@rth rth merged commit 01c9ef3 into scikit-learn:master Feb 2, 2020
thomasjpfan added a commit to thomasjpfan/scikit-learn that referenced this pull request Feb 22, 2020
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mutual_info_classif returns a negative estimated mutual information
3 participants