[MRG] _get_estimators_indices() in BaseBagging class does not generate indices properly by chofchof · Pull Request #16437 · scikit-learn/scikit-learn

chofchof · 2020-02-13T08:22:26Z

Reference Issues/PRs

What does this implement/fix? Explain your changes.

It solves the bug reported by the issue #16436, _get_estimators_indices() in BaseBagging class does not generate indices properly.

As Joel Nothman suggested, the seed is passed directly into _generate_bagging_indices() instead of the numpy RandomState object generated by the seed.

Any other comments?

None.

jnothman · 2020-02-13T08:56:53Z

Thanks for the pull request!
Tests are failing. And you'll need to add a new one to test this issue.
Thanks for the pull request! Please make the title of the PR more descriptive. The title will become the commit message when this is merged. You should state what issue (or PR) it fixes/resolves in the description using the syntax described here.

glemaitre

As a regression test, you can use the one that you reported in the issue. This is good.

glemaitre · 2020-02-13T15:32:02Z

I am wondering if we have something similar regarding the feature indices?

glemaitre · 2020-02-13T15:34:32Z

Regarding the failing tests, this is due to the change of the score in one of the docstring. This should be corrected as well.

chofchof · 2020-02-14T01:43:54Z

I am wondering if we have something similar regarding the feature indices?

No similar problem regarding the feature_indices. The method _get_estimators_indices() is used only in the property estimators_samples_, but this property takes sample_indices only.

glemaitre

Please add an entry to the change log at doc/whats_new/v0.23.rst under bug fixes. Like the other entries there, please reference this pull request with :pr: and credit yourself (and other contributors if applicable) with :user:

I think that we change the behaviour of ExtraTrees* as well, so we should add a note in the what's new on the top (change in behaviour section)

Co-Authored-By: Guillaume Lemaitre <g.lemaitre58@gmail.com>

…into issue_16436

chofchof · 2020-02-17T04:10:05Z

Please add an entry to the change log at doc/whats_new/v0.23.rst under bug fixes. Like the other entries there, please reference this pull request with :pr: and credit yourself (and other contributors if applicable) with :user:

Added an entry to the change log as you suggested. Thanks a lot.
May I add your name as a contributor?

I think that we change the behaviour of ExtraTrees* as well, so we should add a note in the what's new on the top (change in behaviour section)

I have no idea on this one. Do I have to do something more?

glemaitre · 2020-02-17T09:41:28Z

May I add your name as a contributor?

No need for this

glemaitre

Apart from correcting the what's new entry, everything looks good.
We will need a second review.

@jnothman Could you have a look at this one?

glemaitre · 2020-02-19T08:45:22Z

I push a quick reformatting of the what's new to follow the 80 characters limit.
@jnothman I think it looks good now.

rth

Thanks @chofchof ! LGTM.

Pull requests for Issues #16436

70673ec

glemaitre reviewed Feb 13, 2020

View reviewed changes

Comment thread sklearn/ensemble/_bagging.py Outdated

Comment thread sklearn/ensemble/_bagging.py Outdated

chofchof changed the title ~~Pull requests for Issues #16436~~ [WIP] _get_estimators_indices() in BaseBagging class does not generate indices properly Feb 14, 2020

chofchof added 3 commits February 14, 2020 10:18

Rewrite as glemaitre suggested

6f2b78e

Rewrite as glemaitre suggested

b1d099a

Solves the docstring conflict

0b0c8d5

chofchof closed this Feb 14, 2020

chofchof reopened this Feb 14, 2020

chofchof added 3 commits February 14, 2020 13:30

Add regression test

d6dd9ea

Solve lint check

7059c11

Merge remote-tracking branch 'upstream/master' into issue_16436

9703230

chofchof changed the title ~~[WIP] _get_estimators_indices() in BaseBagging class does not generate indices properly~~ [MRG] _get_estimators_indices() in BaseBagging class does not generate indices properly Feb 14, 2020

chofchof requested a review from glemaitre February 14, 2020 07:24

glemaitre reviewed Feb 14, 2020

View reviewed changes

Comment thread sklearn/ensemble/tests/test_bagging.py

Comment thread sklearn/ensemble/tests/test_bagging.py Outdated

Comment thread sklearn/ensemble/tests/test_bagging.py

Comment thread sklearn/ensemble/tests/test_bagging.py Outdated

Comment thread sklearn/ensemble/tests/test_bagging.py Outdated

chofchof and others added 5 commits February 17, 2020 09:53

Update sklearn/ensemble/tests/test_bagging.py

3f1eb7a

Co-Authored-By: Guillaume Lemaitre <g.lemaitre58@gmail.com>

Merge branch 'issue_16436' of https://github.com/chofchof/scikit-learn …

73ebd55

…into issue_16436

Arranged test codes as glemaitre suggested

78d6637

Update a missing line

de57c5c

Add an entry to the change log

b62f2d3

chofchof requested a review from glemaitre February 17, 2020 04:40

glemaitre reviewed Feb 17, 2020

View reviewed changes

Comment thread doc/whats_new/v0.23.rst Outdated

glemaitre reviewed Feb 17, 2020

View reviewed changes

Comment thread doc/whats_new/v0.23.rst

glemaitre approved these changes Feb 17, 2020

View reviewed changes

jnothman reviewed Feb 17, 2020

View reviewed changes

Comment thread doc/whats_new/v0.23.rst Outdated

Comment thread sklearn/ensemble/tests/test_bagging.py Outdated

Modified as suggested by glemaitre and jnothman

315768f

chofchof requested a review from jnothman February 19, 2020 02:46

formatting what's new

363685f

rth approved these changes Feb 20, 2020

View reviewed changes

rth merged commit baa4f07 into scikit-learn:master Feb 20, 2020

thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Feb 22, 2020

FIX _get_estimators_indices() in BaseBagging (scikit-learn#16437)

a5727cf

panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020

FIX _get_estimators_indices() in BaseBagging (scikit-learn#16437)

7724dae

gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020

FIX _get_estimators_indices() in BaseBagging (scikit-learn#16437)

8d14bfa

NicolasHug mentioned this pull request Apr 14, 2021

IsolationForest generates different results across different sklearn versions #19900

Closed

Uh oh!

Uh oh!

Conversation

chofchof commented Feb 13, 2020

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

Uh oh!

jnothman commented Feb 13, 2020

Uh oh!

glemaitre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

glemaitre commented Feb 13, 2020

Uh oh!

glemaitre commented Feb 13, 2020

Uh oh!

chofchof commented Feb 14, 2020

Uh oh!

glemaitre left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chofchof commented Feb 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

glemaitre commented Feb 17, 2020

Uh oh!

glemaitre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

glemaitre commented Feb 19, 2020

Uh oh!

rth left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

glemaitre left a comment •

edited

Loading

chofchof commented Feb 17, 2020 •

edited

Loading