Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Fix Birch n_clusters accepted types #16484

Merged
merged 2 commits into from Feb 19, 2020
Merged

[MRG] Fix Birch n_clusters accepted types #16484

merged 2 commits into from Feb 19, 2020

Conversation

jeremiedbb
Copy link
Member

Fixes #16482

@jeremiedbb jeremiedbb mentioned this pull request Feb 19, 2020
Closed
@jeremiedbb jeremiedbb changed the title Fix Birch n_clusters accepted types [MRG] Fix Birch n_clusters accepted types Feb 19, 2020
thomasjpfan
thomasjpfan approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that test_birch_n_clusters_long_int fails on master.

LGTM

@glemaitre glemaitre merged commit 11934e1 into scikit-learn:master Feb 19, 2020
@glemaitre
Copy link
Contributor

thanks @jeremiedbb

thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Feb 22, 2020
@jeremiedbb @thomasjpfan
BUG accept all integer types as n_clusters in Birch (scikit-learn#16484)
d1596d3
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
@jeremiedbb @panpiort
BUG accept all integer types as n_clusters in Birch (scikit-learn#16484)
cfd90e1
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
@jeremiedbb @gio8tisu
BUG accept all integer types as n_clusters in Birch (scikit-learn#16484)
888a54d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Birch Clustering doesn't work with np.int
3 participants
@jeremiedbb @glemaitre @thomasjpfan