Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Fixes HistGradientBoosting when warm_start is on + early_stopping is on + no validation #16663

merged 4 commits into from Mar 11, 2020


Copy link

@thomasjpfan thomasjpfan commented Mar 10, 2020

Reference Issues/PRs

Fixes #16661

What does this implement/fix? Explain your changes.

Defines raw_predictions_val + adds a test non regression test.

Any other comments?

Do we want to backport this fix?

CC @NicolasHug

Copy link

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if green!

@glemaitre glemaitre merged commit cdbda0e into scikit-learn:master Mar 11, 2020
ashutosh1919 pushed a commit to ashutosh1919/scikit-learn that referenced this pull request Mar 13, 2020
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

HistGradientBoostingClassifier fails for early stopping on the test set with warm start
3 participants