BUG Fixes kernel PCA raising "invalid value encountered in mul…#16718
Merged
Conversation
jnothman
approved these changes
Mar 19, 2020
jnothman
reviewed
Mar 19, 2020
Member
jnothman
left a comment
jnothman
left a comment
There was a problem hiding this comment.
Please add a |Fix| entry to the change log at doc/whats_new/v0.23.rst. Like the other entries there, please reference this pull request with :pr: and credit yourself (and other contributors if applicable) with :user:
thomasjpfan
approved these changes
Mar 19, 2020
Member
thomasjpfan
left a comment
thomasjpfan
left a comment
There was a problem hiding this comment.
@gui-miotto I see this is your first time contributing, welcome!
LGTM
thomasjpfan
changed the title
Contributor
Author
|
Thanks, @thomasjpfan . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
closes #16717
What does this implement/fix? Explain your changes.
Avoids multiplication on an uninitialized matrix created with
np.empty_like()Any other comments?