Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG Fixes kernel PCA raising "invalid value encountered in mul… #16718

Merged
merged 2 commits into from
Mar 19, 2020
Merged

BUG Fixes kernel PCA raising "invalid value encountered in mul… #16718

merged 2 commits into from
Mar 19, 2020

Conversation

gui-miotto
Copy link
Contributor

Reference Issues/PRs

closes #16717

What does this implement/fix? Explain your changes.

Avoids multiplication on an uninitialized matrix created with np.empty_like()

Any other comments?

jnothman
jnothman reviewed Mar 19, 2020
View reviewed changes
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a |Fix| entry to the change log at doc/whats_new/v0.23.rst. Like the other entries there, please reference this pull request with :pr: and credit yourself (and other contributors if applicable) with :user:

thomasjpfan
thomasjpfan approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gui-miotto I see this is your first time contributing, welcome!

LGTM

@thomasjpfan thomasjpfan changed the title Fixes kernel PCA raising "invalid value encountered in multiply" BUG Fixes kernel PCA raising "invalid value encountered in mul… Mar 19, 2020
@thomasjpfan thomasjpfan merged commit b9692a6 into scikit-learn:master Mar 19, 2020
@gui-miotto
Copy link
Contributor Author

Thanks, @thomasjpfan .

@gui-miotto gui-miotto mentioned this pull request Mar 19, 2020
Closed
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
@gui-miotto @gio8tisu
BUG Fixes kernel PCA raising "invalid value encountered in mul… (scik…
03b55c5 
…it-learn#16718)
@charlesfu4 charlesfu4 mentioned this pull request Jun 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:decomposition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kernel PCA raises "invalid value encountered in multiply" at random times
3 participants
@gui-miotto @jnothman @thomasjpfan