Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT removed _safe_tags utility #16950

merged 9 commits into from Apr 19, 2020


Copy link

I think the function of _safe_tags is now properly fulfilled by the _get_tags() logic (probably since #14884)

Copy link

rth commented Apr 17, 2020

This would be indeed great.

I think the function of _safe_tags is now properly fulfilled by the _get_tags() logic (probably since #14884)

@amueller could you confirm? I don't remember all the details, just that it was complicated :)

Copy link

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member Author

Thanks for the related fixes @thomasjpfan

This one should be good to go?

@thomasjpfan thomasjpfan changed the title [MRG] MNT removed _safe_tags utility MNT removed _safe_tags utility Apr 19, 2020
@thomasjpfan thomasjpfan merged commit cb49ad4 into scikit-learn:master Apr 19, 2020
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants