[MRG] Added n_components_ to SparsePCA and MiniBatchSparsePCA - #16981
Merged
Conversation
gorski-m
changed the title
Contributor
Author
|
@TomDLT could you have a look? |
Contributor
Author
|
@jnothman @adrinjalali could you have a look? |
thomasjpfan
reviewed
Apr 26, 2020
thomasjpfan
left a comment
thomasjpfan
left a comment
Member
There was a problem hiding this comment.
Thank you for the PR @Reksbril
thomasjpfan
changed the title
Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>
Member
|
@thomasjpfan does this have your approval? |
thomasjpfan
approved these changes
Apr 27, 2020
Member
|
tagging for inclusion #17010 |
adrinjalali
pushed a commit
that referenced
this pull request
Apr 30, 2020
* Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA * Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA * Add whatsnew entry * Fix documentation * Apply suggestions from code review Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * Add suggested changes * Update test_sparse_pca.py Co-authored-by: Mateusz Górski <mateuszg122@gmail.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
…earn#16981) * Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA * Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA * Add whatsnew entry * Fix documentation * Apply suggestions from code review Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * Add suggested changes * Update test_sparse_pca.py Co-authored-by: Mateusz Górski <mateuszg122@gmail.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
…earn#16981) * Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA * Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA * Add whatsnew entry * Fix documentation * Apply suggestions from code review Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * Add suggested changes * Update test_sparse_pca.py Co-authored-by: Mateusz Górski <mateuszg122@gmail.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
I've added n_components_ parameter to SparsePCA and MiniBatchSparsePCA classes to match the behavior of PCA class. See #16752