Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Add iterable values support for dictvectorizer #17367

Merged
merged 68 commits into from Aug 1, 2020
Merged

[MRG] Add iterable values support for dictvectorizer #17367

merged 68 commits into from Aug 1, 2020

Conversation

cmarmo
Copy link
Member

@cmarmo cmarmo commented May 27, 2020 •
edited

Reference Issues/PRs

Closes #6045
Closes #6369
Resumes #8750

What does this implement/fix? Explain your changes.

Add iterable support for value types in dictvectorizer

@cmarmo cmarmo changed the title [WIP] Add iterable values support for dictvectorizer [MRG] Add iterable values support for dictvectorizer May 28, 2020
@cmarmo
Copy link
Member Author

cmarmo commented May 28, 2020 •
edited

@jnothman, do you mind having a look when you have some time? I'm not sure your comment is addressed correctly. Thanks!

@cmarmo
Copy link
Member Author

cmarmo commented Jun 19, 2020

Gentle ping for ... maybe @thomasjpfan ? Thanks!

jnothman
jnothman requested changes Jul 6, 2020
View reviewed changes
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it seems we are not quite there, but we are very close!

@cmarmo cmarmo requested a review from jnothman July 28, 2020 11:28
@ogrisel
Copy link
Member

ogrisel commented Jul 29, 2020

@jnothman it seems that all the comments of your last review have been addressed. Merge?

jnothman
jnothman reviewed Jul 30, 2020
View reviewed changes
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it seems these comments did not submit correctly

doc/modules/feature_extraction.rst Outdated Show resolved Hide resolved
sklearn/feature_extraction/tests/test_dict_vectorizer.py Outdated Show resolved Hide resolved
@cmarmo cmarmo requested a review from jnothman July 31, 2020 11:52
jnothman
jnothman approved these changes Aug 1, 2020
View reviewed changes
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cmarmo. Sorry it went back and forth. Just realised the change log could say Feature instead of Enhancement. Either way, I guess.

@jnothman jnothman merged commit 320b4c6 into scikit-learn:master Aug 1, 2020
7 checks passed
@cmarmo
Copy link
Member Author

cmarmo commented Aug 1, 2020

Thanks @jnothman and @ogrisel!

@cmarmo cmarmo deleted the multi-value-dict-vec branch August 1, 2020 13:05
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@cmarmo @yupbank
@thomasjpfan @jnothman @jayzed82
FEA Add iterable values support for dictvectorizer (scikit-learn#17367)
ec6e863 

Co-authored-by: Peng Yu <peng.yu@shopify.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Joel Nothman <joel.nothman@gmail.com>
@glemaitre glemaitre mentioned this pull request Apr 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan left review comments

@jnothman jnothman jnothman approved these changes

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
module:feature_extraction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accept multiple values for one categorical feature
5 participants
@cmarmo @jnothman @ogrisel @thomasjpfan @yupbank