Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Deprecate coef_ and intercept_ in naive bayes estimators #17427

Merged
merged 12 commits into from Jul 5, 2020
Merged

MNT Deprecate coef_ and intercept_ in naive bayes estimators #17427

merged 12 commits into from Jul 5, 2020

Conversation

alfaro96
Copy link
Member

@alfaro96 alfaro96 commented Jun 2, 2020

Reference Issues/PRs

Closes #2237.

What does this implement/fix? Explain your changes.

This PR deprecates the attributes coef_ and intercept_ in sklearn.naive_bayes.MultinomialNB, sklearn.naive_bayes.BernoulliNB and sklearn.naive_bayes.CategoricalNB.

@alfaro96 alfaro96 changed the title Deprecate coef intercept naive bayes MNT Deprecate coef_ and intercept_ in naive bayes estimators Jun 2, 2020
thomasjpfan
thomasjpfan reviewed Jun 3, 2020
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @alfaro96

sklearn/tests/test_docstring_parameters.py Outdated Show resolved Hide resolved
sklearn/tests/test_naive_bayes.py Show resolved Hide resolved
sklearn/tests/test_naive_bayes.py Show resolved Hide resolved
@alfaro96
Copy link
Member Author

alfaro96 commented Jun 4, 2020

Thank you for the PR @alfaro96

Thanks for the review @thomasjpfan!

thomasjpfan
thomasjpfan reviewed Jun 4, 2020
View reviewed changes
sklearn/tests/test_naive_bayes.py Show resolved Hide resolved
sklearn/tests/test_naive_bayes.py Outdated Show resolved Hide resolved
@glemaitre glemaitre mentioned this pull request Jun 25, 2020
Merged
@glemaitre glemaitre added this to TO REVIEW in Guillaume's pet Jun 25, 2020
@glemaitre
Copy link
Contributor

@alfaro96 We are going to introduce the attributes coef_ and intercept_ in the documentation for completness: #17722

Once merged, I think your PR can add the .. deprecated:: tag in the documentation as well.

@alfaro96
Copy link
Member Author

@alfaro96 We are going to introduce the attributes coef_ and intercept_ in the documentation for completness: #17722

Once merged, I think your PR can add the .. deprecated:: tag in the documentation as well.

Sure. Go ahead!

@alfaro96 alfaro96 requested a review from thomasjpfan July 1, 2020 10:07
thomasjpfan
thomasjpfan approved these changes Jul 4, 2020
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnothman
Copy link
Member

jnothman commented Jul 5, 2020

Thanks @alfaro96

@jnothman jnothman merged commit 3561802 into scikit-learn:master Jul 5, 2020
7 checks passed
@glemaitre glemaitre moved this from TO REVIEW to TO BE MERGED in Guillaume's pet Jul 7, 2020
@glemaitre glemaitre moved this from TO BE MERGED to MERGED in Guillaume's pet Jul 7, 2020
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Jul 17, 2020
@alfaro96 @glemaitre
MNT Deprecate coef_ and intercept_ in naive bayes estimators (scikit-…
3db2531 
…learn#17427)
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@alfaro96 @jayzed82
MNT Deprecate coef_ and intercept_ in naive bayes estimators (scikit-…
098cfa9 
…learn#17427)
@alfaro96 alfaro96 deleted the deprecate_coef_intercept_naive_bayes branch November 11, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:naive_bayes
Projects
Guillaume's pet
MERGED
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Naive Bayes has the wrong coef_ and intercept_
4 participants
@alfaro96 @glemaitre @jnothman @thomasjpfan