Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Get rid of temporary dictionary in _deprecate_positional_args #17603

merged 1 commit into from Jun 16, 2020


Copy link

dict.update accepts either a dictionary or an interable of tuples, so there is no need to convert the iterable of tuples to a dictionary first.

Copy link

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@thomasjpfan thomasjpfan merged commit f38d381 into scikit-learn:master Jun 16, 2020
@alexhenrie alexhenrie deleted the zip branch June 16, 2020 04:54
rubywerman pushed a commit to MLH-Fellowship/scikit-learn that referenced this pull request Jun 24, 2020
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants