FIX Enforce strict column name order/count in ColumnTransformer #18256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gentle reminder. |
|
@glemaitre @ogrisel, I've labeled as blocker because this pull request finalize some deprecations and remove TODOs for 0.24. Do you mind having a look? Thanks @madhuracj for your work and your patience. |
thomasjpfan
reviewed
Nov 25, 2020
glemaitre
reviewed
Nov 26, 2020
|
I made a small pushed to make the changes and I will add an entry in what's new |
jeremiedbb
approved these changes
Nov 26, 2020
thomasjpfan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Reference Issues/PRs
See #14223, #14237, #14251 and #14544
What does this implement/fix? Explain your changes.
This PR enforces strict column name order and count in ColumnTransformer and cleans up the intermediary codes that were used while the previous behaviour was being deprecated.
Basically, these changes are TODOs marked for v0.24.
Any other comments?