FIX Preserve parameters when slicing a pipeline #18429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
approved these changes
Sep 20, 2020
sklearn/tests/test_pipeline.py
Outdated
| assert pipe2.steps == pipe.steps[:-1] | ||
| assert 2 == len(pipe2.named_steps) | ||
| assert_raises(ValueError, lambda: pipe[::-1]) | ||
| @pytest.mark.parametrize("start, end", [(0, 1), (0, 2), (1, 2), (1, 3)]) |
There was a problem hiding this comment.
Please test one or both of the indices being None
There was a problem hiding this comment.
Done @jnothman
|
Many thanks @albertvillanova for seeing these changes through, I couldn't find the time to finish the original PR. |
|
@pwl, you are welcome. |
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
Co-authored-by: Paweł Biernat <pawel.biernat@ardigen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Reference Issues/PRs
Fix #16863.
Supersede and close #16868.