Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing sparse inputs for prediction in AffinityPropagation #20117

Merged
merged 6 commits into from May 27, 2021
Merged

Allowing sparse inputs for prediction in AffinityPropagation #20117

merged 6 commits into from May 27, 2021

Conversation

venkyyuvy
Copy link
Contributor

@venkyyuvy venkyyuvy commented May 20, 2021 •
edited

Reference Issues/PRs

Fixes #20049

What does this implement/fix? Explain your changes.

Accepts sparse data inputs for affinitiy propagation model.

jeremiedbb
jeremiedbb approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @venkyyuvy ! Just a few minor comments

doc/whats_new/v1.0.rst Outdated Show resolved Hide resolved
sklearn/cluster/tests/test_affinity_propagation.py Outdated Show resolved Hide resolved
sklearn/cluster/tests/test_affinity_propagation.py Outdated Show resolved Hide resolved
@venkyyuvy venkyyuvy requested a review from jeremiedbb May 23, 2021 07:30
ogrisel
ogrisel approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. Let me just rephrase the changelog a bit to make it more precise.

doc/whats_new/v1.0.rst Outdated Show resolved Hide resolved
@jeremiedbb jeremiedbb merged commit aa86c83 into scikit-learn:main May 27, 2021
@jeremiedbb
Copy link
Member

thanks @venkyyuvy !

thomasjpfan pushed a commit to bsun94/scikit-learn that referenced this pull request Jun 5, 2021
@venkyyuvy @thomasjpfan
ENH Allowing sparse inputs for prediction in AffinityPropagation (sci…
4018fc8 
…kit-learn#20117)
@milana2 milana2 mentioned this pull request Aug 11, 2021
Closed
@milana2 milana2 mentioned this pull request Aug 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@jeremiedbb jeremiedbb Awaiting requested review from jeremiedbb

Assignees
No one assigned
Labels
Enhancement module:cluster Waiting for Reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AffinityPropagation predict does not accept sparse X
4 participants
@venkyyuvy @jeremiedbb @ogrisel @cmarmo