Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Fixes typo in plot_permutation_test_for_classification #20622

Conversation

GaelVaroquaux
Copy link
Member

This PR fixes a trivial typo.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan changed the title Fix typo DOC Fix typo Jul 27, 2021
@thomasjpfan thomasjpfan changed the title DOC Fix typo DOC Fixes typo in plot_permutation_test_for_classification Jul 27, 2021
@thomasjpfan thomasjpfan merged commit df20e81 into scikit-learn:main Jul 27, 2021
@GaelVaroquaux
Copy link
Member Author

Thanks for changing the title @thomasjpfan !

By the way, this example seems in a strange place, doesn't it. I would have rather seen it in the model_selection directory.

@thomasjpfan
Copy link
Member

By the way, this example seems in a strange place, doesn't it. I would have rather seen it in the model_selection directory.

I agree. This example looks like it belongs in model_selection.

TomDLT pushed a commit to TomDLT/scikit-learn that referenced this pull request Jul 29, 2021
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants