FIX better handle limit cases in normalized_mutual_info_score #22635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
changed the title
thomasjpfan
reviewed
Mar 1, 2022
There was a problem hiding this comment.
Thanks for the PR!
With the explicit handling of constant clusters. I think we can remove:
scikit-learn/sklearn/metrics/cluster/_supervised.py
Lines 1038 to 1039 in 9ced5ec
I agree. Now the only way to have an entropy < eps would be to have a single one in an array of approx 10^17 zeros which is a big unrealistic array :) |
glemaitre
approved these changes
Mar 2, 2022
|
Thanks @jeremiedbb |
This was referenced Mar 13, 2022
mathijs02
pushed a commit
to mathijs02/scikit-learn
that referenced
this pull request
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13836
by better handling of limit cases, i.e when 1 or both labelling are constant, i.e. there's a single cluster.