-
-
Notifications
You must be signed in to change notification settings - Fork 25.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Adds FeatureUnion.__getitem__ to access transformers #25093
ENH Adds FeatureUnion.__getitem__ to access transformers #25093
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good modulo the test modification.
Co-authored-by: Meekail Zain <34613774+Micky774@users.noreply.github.com>
The |
I do not think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Fine with me not to support slicing. Can you write down a short summary of the thought process so people from the future (and for my education) can find out?
For me, I do not see a good user story for adding slices to Logistically, I prefer to have a more restrictive feature and only consider expanding it when there is a need. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
Reference Issues/PRs
Closes #24906
What does this implement/fix? Explain your changes.
This PR adds
__getitem__
toFeatureUnion
to access transformers.