ENH Add custom_range argument for partial dependence - version 2#26202
Merged
adrinjalali merged 87 commits intoNov 19, 2024
Merged
Conversation
…bset of features.
…bset of features.
Member
|
We will not make it for 1.6. I moving the milestone to 1.7 |
adrinjalali
reviewed
Nov 7, 2024
…ement.rst Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Contributor
Author
Thanks for the suggestions, I haven't had much time to look at this recently. I will also update the version number to specify 1.7. |
Contributor
Author
|
@adrinjalali I think I have addressed all your comments. I have fixed a separate issue here, but can split that out if desired. |
adrinjalali
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #20890 and is a followup to the stale PR - #21033
Also fixes #30271
What does this implement/fix? Explain your changes.
This PR allows users to specify a custom_range of values to calculate partial depedency for some or all of the features.
The api is custom_range={feature: array-like of grid values}.
Any other comments?